Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2936893002: [ObjC ARC] Converts ios/web:ios_web_webui_unittests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org, viettrungluu+watch_chromium.org, ios-reviews+web_chromium.org, Eugene But (OOO till 7-30), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), qsr+mojo_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_webui_unittests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2936893002 Cr-Commit-Position: refs/heads/master@{#479398} Committed: https://chromium.googlesource.com/chromium/src/+/8317b2b8983970ab5ac05d91d711e00cdb2a8bc1

Patch Set 1 #

Total comments: 2

Patch Set 2 : MakeUnique #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -26 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager_unittest.mm View 6 chunks +12 lines, -10 lines 0 comments Download
M ios/web/webui/crw_web_ui_page_builder_unittest.mm View 2 chunks +9 lines, -6 lines 0 comments Download
M ios/web/webui/mojo_facade_unittest.mm View 1 5 chunks +13 lines, -10 lines 0 comments Download
M ios/web/webui/url_fetcher_block_adapter_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-13 19:19:52 UTC) #6
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2936893002/diff/1/ios/web/webui/mojo_facade_unittest.mm File ios/web/webui/mojo_facade_unittest.mm (right): https://codereview.chromium.org/2936893002/diff/1/ios/web/webui/mojo_facade_unittest.mm#newcode61 ios/web/webui/mojo_facade_unittest.mm:61: new MojoFacade(interface_provider_.get(), Optional nit unrelated to ARC: s/new/MakeUnique
3 years, 6 months ago (2017-06-14 01:03:08 UTC) #7
marq (ping after 24h)
Thanks for the review! https://codereview.chromium.org/2936893002/diff/1/ios/web/webui/mojo_facade_unittest.mm File ios/web/webui/mojo_facade_unittest.mm (right): https://codereview.chromium.org/2936893002/diff/1/ios/web/webui/mojo_facade_unittest.mm#newcode61 ios/web/webui/mojo_facade_unittest.mm:61: new MojoFacade(interface_provider_.get(), On 2017/06/14 01:03:08, ...
3 years, 6 months ago (2017-06-14 11:59:16 UTC) #8
marq (ping after 24h)
MakeUnique
3 years, 6 months ago (2017-06-14 11:59:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936893002/20001
3 years, 6 months ago (2017-06-14 11:59:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/199675)
3 years, 6 months ago (2017-06-14 14:37:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936893002/20001
3 years, 6 months ago (2017-06-14 14:49:30 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 15:45:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8317b2b8983970ab5ac05d91d711...

Powered by Google App Engine
This is Rietveld 408576698