Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2936883002: Revert of Disable search functionality in ChromeActivity before search promo check (Closed)

Created:
3 years, 6 months ago by Yusuf
Modified:
3 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable search functionality in ChromeActivity before search promo check (patchset #5 id:80001 of https://codereview.chromium.org/2926413002/ ) Reason for revert: crbug.com/732680 Original issue's description: > Disable search functionality in ChromeActivity before search promo check > > - Disable contextual search before we go through the search engine promo > check > - On a WebSearch from selection, first show the search engine promo and > only after that send the search intent. > > BUG=728891 > > Review-Url: https://codereview.chromium.org/2926413002 > Cr-Commit-Position: refs/heads/master@{#478677} > Committed: https://chromium.googlesource.com/chromium/src/+/21f504945ba3712f0455a1b3711dcf576cda5ee3 TBR=tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=728891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 3 chunks +3 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 3 chunks +4 lines, -17 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Yusuf
Created Revert of Disable search functionality in ChromeActivity before search promo check
3 years, 6 months ago (2017-06-13 17:04:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936883002/1
3 years, 6 months ago (2017-06-13 17:04:14 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 17:04:27 UTC) #5
Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1378
  Falling back to three-way merge...
  Applied patch to
'chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java' with
conflicts.
  U chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index
07a959b1e654d827c9f000535257b9a1821bf320..289dad8178c97d3332aba8c2c1dae7a747c6ef29
100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -88,7 +88,6 @@
 import org.chromium.chrome.browser.infobar.InfoBarContainer;
 import org.chromium.chrome.browser.init.AsyncInitializationActivity;
 import org.chromium.chrome.browser.init.ProcessInitializationHandler;
-import org.chromium.chrome.browser.locale.LocaleManager;
 import org.chromium.chrome.browser.media.PictureInPictureController;
 import org.chromium.chrome.browser.metrics.LaunchMetrics;
 import org.chromium.chrome.browser.metrics.StartupMetrics;
@@ -741,7 +740,7 @@
      * @return Whether contextual search is allowed for this activity or not.
      */
     protected boolean isContextualSearchAllowed() {
-        return !LocaleManager.getInstance().needToCheckForSearchEnginePromo();
+        return true;
     }
 
     @Override
@@ -1378,18 +1377,9 @@
         return new IntentHandlerDelegate() {
             @Override
             public void processWebSearchIntent(String query) {
-                final Intent searchIntent = new
Intent(Intent.ACTION_WEB_SEARCH);
+                Intent searchIntent = new Intent(Intent.ACTION_WEB_SEARCH);
                 searchIntent.putExtra(SearchManager.QUERY, query);
-                Callback<Boolean> callback = new Callback<Boolean>() {
-                    @Override
-                    public void onResult(Boolean result) {
-                        if (result != null && result)
startActivity(searchIntent);
-                    }
-                };
-                if (!LocaleManager.getInstance().showSearchEnginePromoIfNeeded(
-                            ChromeActivity.this, callback)) {
-                    callback.onResult(true);
-                }
+                startActivity(searchIntent);
             }
 
             @Override

Powered by Google App Engine
This is Rietveld 408576698