Disable search functionality in ChromeActivity before search promo check

Disable search functionality in ChromeActivity before search promo check

- Disable contextual search before we go through the search engine promo
check
- On a WebSearch from selection, first show the search engine promo and
only after that send the search intent.

BUG=728891
Review-Url: https://codereview.chromium.org/2926413002
Cr-Commit-Position: refs/heads/master@{#478677}
Committed: https://chromium.googlesource.com/chromium/src/+/21f504945ba3712f0455a1b3711dcf576cda5ee3

[Yusuf, 2017-06-08 22:20:52]

yusufo@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2017-06-08 22:41:36]

lgtm

https://codereview.chromium.org/2926413002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2926413002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1386:
startActivity(searchIntent);
does this need to be:
if (result != null && result) startActivity(searchIntent);

[Yusuf, 2017-06-08 22:46:56]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2017-06-08 22:46:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2926413002/#ps20001
(title: "search based on result")

[Yusuf, 2017-06-08 22:47:12]

https://codereview.chromium.org/2926413002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2926413002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1386:
startActivity(searchIntent);
On 2017/06/08 22:41:36, Ted C wrote:
> does this need to be:
> if (result != null && result) startActivity(searchIntent);

Done.

[commit-bot: I haz the power, 2017-06-08 22:47:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 01:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 01:41:26]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yusuf, 2017-06-09 17:22:44]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2017-06-09 17:22:45]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2926413002/#ps40001
(title: "make tests happy")

[commit-bot: I haz the power, 2017-06-09 17:23:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuf, 2017-06-09 18:43:44]

The CQ bit was unchecked by yusufo@chromium.org

[Yusuf, 2017-06-09 18:45:55]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2017-06-09 18:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2926413002/#ps60001
(title: "strictmode")

[commit-bot: I haz the power, 2017-06-09 18:46:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 20:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 20:57:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yusuf, 2017-06-12 17:13:17]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2017-06-12 17:13:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2926413002/#ps80001
(title: "tests")

[commit-bot: I haz the power, 2017-06-12 17:13:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:00:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497287597212270,
"parent_rev": "528c7c50c9e45cdff5bcbc192d0c341ffac56ce7", "commit_rev":
"21f504945ba3712f0455a1b3711dcf576cda5ee3"}

[commit-bot: I haz the power, 2017-06-12 18:01:04]

Description was changed from

==========
Disable search functionality in ChromeActivity before search promo check

- Disable contextual search before we go through the search engine promo
check
- On a WebSearch from selection, first show the search engine promo and
only after that send the search intent.

BUG=728891
==========

to

==========
Disable search functionality in ChromeActivity before search promo check

- Disable contextual search before we go through the search engine promo
check
- On a WebSearch from selection, first show the search engine promo and
only after that send the search intent.

BUG=728891

Review-Url: https://codereview.chromium.org/2926413002
Cr-Commit-Position: refs/heads/master@{#478677}
Committed:
https://chromium.googlesource.com/chromium/src/+/21f504945ba3712f0455a1b3711d...
==========

[commit-bot: I haz the power, 2017-06-12 18:01:05]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/21f504945ba3712f0455a1b3711d...

[Yusuf, 2017-06-13 17:04:07]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2936883002/ by yusufo@chromium.org.

The reason for reverting is: crbug.com/732680.