Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2936853003: VR: Send separate down and up events for controller clicks. (Closed)

Created:
3 years, 6 months ago by mthiesse
Modified:
3 years, 6 months ago
Reviewers:
asimjour1, cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Send separate down and up events for controller clicks. Now with 100% more down and up. https://www.youtube.com/watch?v=qJdMjRHRLfg BUG=732917 Review-Url: https://codereview.chromium.org/2936853003 Cr-Commit-Position: refs/heads/master@{#479143} Committed: https://chromium.googlesource.com/chromium/src/+/99913d0de1ae13773c571a77445571c8fbd2215f

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -24 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 6 chunks +37 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mthiesse
PTAL
3 years, 6 months ago (2017-06-13 19:31:08 UTC) #2
cjgrant
lgtm https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_shell/vr_shell_gl.cc File chrome/browser/android/vr_shell/vr_shell_gl.cc (right): https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_shell/vr_shell_gl.cc#newcode168 chrome/browser/android/vr_shell/vr_shell_gl.cc:168: blink::WebInputEvent::Modifiers mods = s/mods/modifiers/ ? And s/loc/location/ above?
3 years, 6 months ago (2017-06-13 19:39:04 UTC) #3
asimjour1
On 2017/06/13 19:39:04, cjgrant wrote: > lgtm > > https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_shell/vr_shell_gl.cc > File chrome/browser/android/vr_shell/vr_shell_gl.cc (right): > ...
3 years, 6 months ago (2017-06-13 19:48:44 UTC) #4
mthiesse
https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_shell/vr_shell_gl.cc File chrome/browser/android/vr_shell/vr_shell_gl.cc (right): https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_shell/vr_shell_gl.cc#newcode168 chrome/browser/android/vr_shell/vr_shell_gl.cc:168: blink::WebInputEvent::Modifiers mods = On 2017/06/13 19:39:04, cjgrant wrote: > ...
3 years, 6 months ago (2017-06-13 19:55:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936853003/20001
3 years, 6 months ago (2017-06-13 19:56:27 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 20:53:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99913d0de1ae13773c571a774455...

Powered by Google App Engine
This is Rietveld 408576698