VR: Send separate down and up events for controller clicks.

VR: Send separate down and up events for controller clicks.

Now with 100% more down and up.
https://www.youtube.com/watch?v=qJdMjRHRLfg

BUG=732917
Review-Url: https://codereview.chromium.org/2936853003
Cr-Commit-Position: refs/heads/master@{#479143}
Committed: https://chromium.googlesource.com/chromium/src/+/99913d0de1ae13773c571a77445571c8fbd2215f

[mthiesse, 2017-06-13 19:31:07]

mthiesse@chromium.org changed reviewers:
+ asimjour@chromium.org, cjgrant@chromium.org

[mthiesse, 2017-06-13 19:31:08]

PTAL

[cjgrant, 2017-06-13 19:39:04]

lgtm

https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:168:
blink::WebInputEvent::Modifiers mods =
s/mods/modifiers/ ?  And s/loc/location/ above?

[asimjour1, 2017-06-13 19:48:44]

On 2017/06/13 19:39:04, cjgrant wrote:
> lgtm
> 
>
https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_s...
> File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):
> 
>
https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/vr_shell_gl.cc:168:
> blink::WebInputEvent::Modifiers mods =
> s/mods/modifiers/ ?  And s/loc/location/ above?

lgtm

[mthiesse, 2017-06-13 19:55:45]

https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2936853003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:168:
blink::WebInputEvent::Modifiers mods =
On 2017/06/13 19:39:04, cjgrant wrote:
> s/mods/modifiers/ ?  And s/loc/location/ above?

Done.

[mthiesse, 2017-06-13 19:55:48]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-06-13 19:55:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
asimjour@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2936853003/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2017-06-13 19:56:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 20:53:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497383748440550,
"parent_rev": "f534c4f1aef85310aed3ca0ab432eb1bd1ae9d73", "commit_rev":
"99913d0de1ae13773c571a77445571c8fbd2215f"}

[commit-bot: I haz the power, 2017-06-13 20:53:30]

Description was changed from

==========
VR: Send separate down and up events for controller clicks.

Now with 100% more down and up.
https://www.youtube.com/watch?v=qJdMjRHRLfg

BUG=732917
==========

to

==========
VR: Send separate down and up events for controller clicks.

Now with 100% more down and up.
https://www.youtube.com/watch?v=qJdMjRHRLfg

BUG=732917

Review-Url: https://codereview.chromium.org/2936853003
Cr-Commit-Position: refs/heads/master@{#479143}
Committed:
https://chromium.googlesource.com/chromium/src/+/99913d0de1ae13773c571a774455...
==========

[commit-bot: I haz the power, 2017-06-13 20:53:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99913d0de1ae13773c571a774455...