Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2936773006: Allow overriding script executable in .gn file (Closed)

Created:
3 years, 6 months ago by Petr Hosek
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow overriding script executable in .gn file This eliminates the need for using gn executable wrapper in cases where a custom script interpreter is always being used. Review-Url: https://codereview.chromium.org/2936773006 Cr-Commit-Position: refs/heads/master@{#481105} Committed: https://chromium.googlesource.com/chromium/src/+/a104997ecbfd50c1d6a3399a49c9ad52c198259c

Patch Set 1 #

Patch Set 2 : Allow overriding script executable in .gn file #

Patch Set 3 : Rebase #

Patch Set 4 : Windows path handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -15 lines) Patch
M tools/gn/docs/reference.md View 1 2 6 chunks +19 lines, -5 lines 0 comments Download
M tools/gn/setup.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/setup.cc View 1 2 3 5 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Petr Hosek
In Fuchsia, we always use a custom script interpreter which means we currently have to ...
3 years, 6 months ago (2017-06-14 07:19:34 UTC) #3
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-14 19:45:39 UTC) #4
brettw
lgtm
3 years, 6 months ago (2017-06-20 18:15:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936773006/20001
3 years, 6 months ago (2017-06-20 23:50:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/472414) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 6 months ago (2017-06-21 00:08:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936773006/40001
3 years, 6 months ago (2017-06-21 02:58:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/472532)
3 years, 6 months ago (2017-06-21 03:12:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936773006/60001
3 years, 6 months ago (2017-06-21 03:21:33 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 03:36:39 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a104997ecbfd50c1d6a3399a49c9...

Powered by Google App Engine
This is Rietveld 408576698