[ios clean] Toolbar accessibility and showcase egtests

[ios clean] Adds toolbar accessibility support and showcase egtests

-Adds accessibility labels for all ToolbarButtons.
-Creates Showcase EG tests for the ToolbarVC.

BUG=683793
Review-Url: https://codereview.chromium.org/2936773003
Cr-Commit-Position: refs/heads/master@{#481100}
Committed: https://chromium.googlesource.com/chromium/src/+/4e09a8660ec7e725f73fdb2228b606db19eb5ef5

[sczs, 2017-06-19 20:04:00]

Description was changed from

==========
[draft] Showcase Accessibility utility

BUG=
==========

to

==========
[ios clean] Toolbar showcase egtests

BUG=683793
==========

[sczs, 2017-06-19 20:04:01]

sczs@chromium.org changed reviewers:
+ lpromero@chromium.org, marq@chromium.org

[sczs, 2017-06-19 20:04:11]

Patchset #1 (id:1) has been deleted

[sczs, 2017-06-19 20:05:12]

Description was changed from

==========
[ios clean] Toolbar showcase egtests

BUG=683793
==========

to

==========
[ios clean] Toolbar accessibility and showcase egtests

BUG=683793
==========

[sczs, 2017-06-20 00:28:51]

Patchset #1 (id:20001) has been deleted

[sczs, 2017-06-20 01:12:25]

Description was changed from

==========
[ios clean] Toolbar accessibility and showcase egtests

BUG=683793
==========

to

==========
[ios clean] Adds toolbar accessibility support and showcase egtests

-Adds accessibility labels for all ToolbarButtons.
-Creates Showcase EG tests for the ToolbarVC.

BUG=683793
==========

[sczs, 2017-06-20 01:14:43]

Patchset #1 (id:40001) has been deleted

[sczs, 2017-06-20 01:20:30]

PTAL

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
ios/chrome/app/strings/ios_strings.grd:1430: Home
Wasn't sure on this one, but I know Tab Grid might not have any meaning for
users.

[marq (ping after 24h), 2017-06-20 08:13:39]

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
ios/chrome/app/strings/ios_strings.grd:1430: Home
On 2017/06/20 01:20:30, sczs wrote:
> Wasn't sure on this one, but I know Tab Grid might not have any meaning for
> users. 

How is this different from IDS_IOS_TOOLBAR_SHOW_TABS's "show tabs"?

[lpromero, 2017-06-20 08:38:53]

LGTM with comment.

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
ios/chrome/app/strings/ios_strings.grd:1430: Home
On 2017/06/20 01:20:30, sczs wrote:
> Wasn't sure on this one, but I know Tab Grid might not have any meaning for
> users. 

I am not sure of that. The spatial layout is accessible to VoiceOver users when
they drag the finger around the screen. Moreover, Switch Control users can see
but don't interact with the screen.
Adding a concept of "Home" here could well be detrimental for when we introduce
Chrome Home (even though we might not officially name it).

https://codereview.chromium.org/2936773003/diff/60001/ios/showcase/toolbar/sc...
File ios/showcase/toolbar/sc_toolbar_egtest.mm (right):

https://codereview.chromium.org/2936773003/diff/60001/ios/showcase/toolbar/sc...
ios/showcase/toolbar/sc_toolbar_egtest.mm:44: // Test if the Toolbar buttons
have the right accessibility labels and commands.
Nit: s/Test/Tests here and below.

[sczs, 2017-06-21 01:47:57]

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
ios/chrome/app/strings/ios_strings.grd:1430: Home
On 2017/06/20 08:13:39, marq (ping after 24h) wrote:
> On 2017/06/20 01:20:30, sczs wrote:
> > Wasn't sure on this one, but I know Tab Grid might not have any meaning for
> > users. 
> 
> How is this different from IDS_IOS_TOOLBAR_SHOW_TABS's "show tabs"?

I was thinking that Tabs is something most people know about (We don't hace Show
Tab Strip), but the concept of Tab Grid hasn't been introduced yet.

https://codereview.chromium.org/2936773003/diff/60001/ios/chrome/app/strings/...
ios/chrome/app/strings/ios_strings.grd:1430: Home
On 2017/06/20 08:38:53, lpromero wrote:
> On 2017/06/20 01:20:30, sczs wrote:
> > Wasn't sure on this one, but I know Tab Grid might not have any meaning for
> > users. 
> 
> I am not sure of that. The spatial layout is accessible to VoiceOver users
when
> they drag the finger around the screen. Moreover, Switch Control users can see
> but don't interact with the screen.
> Adding a concept of "Home" here could well be detrimental for when we
introduce
> Chrome Home (even though we might not officially name it).

I was actually thinking about that, since that button would take you to Chrome
Home. I wasn't thinking of Switch Control users, thanks for bringing that up.
Will change this to Show Tab Grid, Home doesn't make as much sense as I thought.

https://codereview.chromium.org/2936773003/diff/60001/ios/showcase/toolbar/sc...
File ios/showcase/toolbar/sc_toolbar_egtest.mm (right):

https://codereview.chromium.org/2936773003/diff/60001/ios/showcase/toolbar/sc...
ios/showcase/toolbar/sc_toolbar_egtest.mm:44: // Test if the Toolbar buttons
have the right accessibility labels and commands.
On 2017/06/20 08:38:53, lpromero wrote:
> Nit: s/Test/Tests here and below.

Done.

[sczs, 2017-06-21 01:49:08]

The CQ bit was checked by sczs@chromium.org

[sczs, 2017-06-21 01:49:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2936773003/#ps80001
(title: "Rename A11y string")

[commit-bot: I haz the power, 2017-06-21 01:49:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 03:21:16]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498009748946280,
"parent_rev": "897ac00a9fb5cfd337069fe821d12268dfbde7d5", "commit_rev":
"4e09a8660ec7e725f73fdb2228b606db19eb5ef5"}

[commit-bot: I haz the power, 2017-06-21 03:21:29]

Description was changed from

==========
[ios clean] Adds toolbar accessibility support and showcase egtests

-Adds accessibility labels for all ToolbarButtons.
-Creates Showcase EG tests for the ToolbarVC.

BUG=683793
==========

to

==========
[ios clean] Adds toolbar accessibility support and showcase egtests

-Adds accessibility labels for all ToolbarButtons.
-Creates Showcase EG tests for the ToolbarVC.

BUG=683793

Review-Url: https://codereview.chromium.org/2936773003
Cr-Commit-Position: refs/heads/master@{#481100}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e09a8660ec7e725f73fdb2228b6...
==========

[commit-bot: I haz the power, 2017-06-21 03:21:31]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4e09a8660ec7e725f73fdb2228b6...