Move safe_browsing.mojom into components/safe_browsing.

Move safe_browsing.mojom into components/safe_browsing.

This way it could be used by Android WebView.

BUG=715673
Review-Url: https://codereview.chromium.org/2936773002
Cr-Commit-Position: refs/heads/master@{#479949}
Committed: https://chromium.googlesource.com/chromium/src/+/f36f0f6fbc6bb6aa4fcce9e68bcf467ff68d65c2

[yzshen1, 2017-06-13 00:32:03]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:32:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 02:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 02:09:53]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-06-13 05:08:27]

yzshen@chromium.org changed reviewers:
+ dcheng@chromium.org, jam@chromium.org, vakh@chromium.org

[yzshen1, 2017-06-13 05:08:28]

Hi,

Would you please take a look? Thanks!

[yzshen1, 2017-06-13 05:12:37]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 05:12:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-06-13 05:35:54]

lgtm

[commit-bot: I haz the power, 2017-06-13 07:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 07:15:36]

Dry run: This issue passed the CQ dry run.

[jam, 2017-06-13 17:57:42]

lgtm

https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
File components/safe_browsing/public/interfaces/safe_browsing.mojom (right):

https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
components/safe_browsing/public/interfaces/safe_browsing.mojom:1: // Copyright
2017 The Chromium Authors. All rights reserved.
nit: since components/safe_browsing is not a service, i think the
"public/interfaces" is redundant. why not just
components/safe_browsing/common/safe_browsing.mojom?

[yzshen1, 2017-06-13 18:12:14]

https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
File components/safe_browsing/public/interfaces/safe_browsing.mojom (right):

https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
components/safe_browsing/public/interfaces/safe_browsing.mojom:1: // Copyright
2017 The Chromium Authors. All rights reserved.
On 2017/06/13 17:57:42, jam (ooo 6-14 - 6-20) wrote:
> nit: since components/safe_browsing is not a service, i think the
> "public/interfaces" is redundant. why not just
> components/safe_browsing/common/safe_browsing.mojom?

I notice that in components/ there are others that are not services but use
public/interfaces for their mojoms. For example: 
https://cs.chromium.org/chromium/src/components/rappor/public/interfaces/rapp...
https://cs.chromium.org/chromium/src/components/ukm/public/interfaces/ukm_int...

I feel that it is easier to find and somewhat more consistent. But if you have
taken this into consideration and still prefer putting it in common/, I will
make the change. Please let me know. Thanks!

[jam, 2017-06-13 23:14:21]

On 2017/06/13 18:12:14, yzshen1 wrote:
>
https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
> File components/safe_browsing/public/interfaces/safe_browsing.mojom (right):
> 
>
https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
> components/safe_browsing/public/interfaces/safe_browsing.mojom:1: // Copyright
> 2017 The Chromium Authors. All rights reserved.
> On 2017/06/13 17:57:42, jam (ooo 6-14 - 6-20) wrote:
> > nit: since components/safe_browsing is not a service, i think the
> > "public/interfaces" is redundant. why not just
> > components/safe_browsing/common/safe_browsing.mojom?
> 
> I notice that in components/ there are others that are not services but use
> public/interfaces for their mojoms. For example: 
>
https://cs.chromium.org/chromium/src/components/rappor/public/interfaces/rapp...
>
https://cs.chromium.org/chromium/src/components/ukm/public/interfaces/ukm_int...
> 
> I feel that it is easier to find and somewhat more consistent. But if you have
> taken this into consideration and still prefer putting it in common/, I will
> make the change. Please let me know. Thanks!

this is a nit so I'll let you decide what you prefer :)

One thing is that these directories don't have browser/common/renderer split
already. historically for components with these subdirs, we put IPCs in the
common/ directory.

[yzshen1, 2017-06-13 23:20:22]

On 2017/06/13 23:14:21, jam (ooo 6-14 - 6-20) wrote:
> On 2017/06/13 18:12:14, yzshen1 wrote:
> >
>
https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
> > File components/safe_browsing/public/interfaces/safe_browsing.mojom (right):
> > 
> >
>
https://codereview.chromium.org/2936773002/diff/20001/components/safe_browsin...
> > components/safe_browsing/public/interfaces/safe_browsing.mojom:1: //
Copyright
> > 2017 The Chromium Authors. All rights reserved.
> > On 2017/06/13 17:57:42, jam (ooo 6-14 - 6-20) wrote:
> > > nit: since components/safe_browsing is not a service, i think the
> > > "public/interfaces" is redundant. why not just
> > > components/safe_browsing/common/safe_browsing.mojom?
> > 
> > I notice that in components/ there are others that are not services but use
> > public/interfaces for their mojoms. For example: 
> >
>
https://cs.chromium.org/chromium/src/components/rappor/public/interfaces/rapp...
> >
>
https://cs.chromium.org/chromium/src/components/ukm/public/interfaces/ukm_int...
> > 
> > I feel that it is easier to find and somewhat more consistent. But if you
have
> > taken this into consideration and still prefer putting it in common/, I will
> > make the change. Please let me know. Thanks!
> 
> this is a nit so I'll let you decide what you prefer :)
> 
> One thing is that these directories don't have browser/common/renderer split
> already. historically for components with these subdirs, we put IPCs in the
> common/ directory.

I see. Thanks for the explanation! I will move the files into common/

[yzshen1, 2017-06-13 23:48:07]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 23:48:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 23:51:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 23:51:30]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vakh (use Gerrit instead), 2017-06-15 21:59:22]

lgtm

[yzshen1, 2017-06-16 00:08:29]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-06-16 00:08:30]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
dcheng@chromium.org, vakh@chromium.org
Link to the patchset: https://codereview.chromium.org/2936773002/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2017-06-16 00:08:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 00:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 00:15:29]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[yzshen1, 2017-06-16 00:41:19]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-06-16 00:41:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 01:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 01:24:05]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vakh (use Gerrit instead), 2017-06-16 03:25:50]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2017-06-16 03:26:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 04:44:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497583550650420,
"parent_rev": "25a2fbbcff72016d5c50e8723e56d565d43f3071", "commit_rev":
"f36f0f6fbc6bb6aa4fcce9e68bcf467ff68d65c2"}

[commit-bot: I haz the power, 2017-06-16 04:45:05]

Description was changed from

==========
Move safe_browsing.mojom into components/safe_browsing.

This way it could be used by Android WebView.

BUG=715673
==========

to

==========
Move safe_browsing.mojom into components/safe_browsing.

This way it could be used by Android WebView.

BUG=715673

Review-Url: https://codereview.chromium.org/2936773002
Cr-Commit-Position: refs/heads/master@{#479949}
Committed:
https://chromium.googlesource.com/chromium/src/+/f36f0f6fbc6bb6aa4fcce9e68bcf...
==========

[commit-bot: I haz the power, 2017-06-16 04:45:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f36f0f6fbc6bb6aa4fcce9e68bcf...