Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2936713002: [heap] Retire the twin brother of CollectGarbage. (Closed)

Created:
3 years, 6 months ago by Hannes Payer (out of office)
Modified:
3 years, 6 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Retire the twin brother of CollectGarbage. BUG= Review-Url: https://codereview.chromium.org/2936713002 Cr-Commit-Position: refs/heads/master@{#45885} Committed: https://chromium.googlesource.com/v8/v8/+/91fb26ec83928d9b1fa3a71cac788634ba89d3b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M src/heap/heap.h View 2 chunks +1 line, -9 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
Michael Lippautz
LGTM
3 years, 6 months ago (2017-06-12 18:59:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936713002/1
3 years, 6 months ago (2017-06-13 07:53:29 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 07:55:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/91fb26ec83928d9b1fa3a71cac788634ba8...

Powered by Google App Engine
This is Rietveld 408576698