Add null check to InfoBarLayout.setIsUsingBigIcon to avoid NPE.

Add null check to InfoBarLayout.setIsUsingBigIcon to avoid NPE.

It's possible for us to get a null icon from getInstantAppLaunchData, so
perform a null check before using the icon in InfoBarLayout.

BUG=731801
Review-Url: https://codereview.chromium.org/2936703002
Cr-Commit-Position: refs/heads/master@{#478787}
Committed: https://chromium.googlesource.com/chromium/src/+/a34648550e4e95f355854e937c0cb1a095833681

[troyhildebrandt, 2017-06-12 18:44:42]

Description was changed from

==========
Add null check to InfoBarLayout.setIsUsingBigIcon to avoid NPE.

It's possible for us to get a null icon from getInstantAppLaunchData, so
perform a null check before using the icon in InfoBarLayout.

BUG=731801
==========

to

==========
Add null check to InfoBarLayout.setIsUsingBigIcon to avoid NPE.

It's possible for us to get a null icon from getInstantAppLaunchData, so
perform a null check before using the icon in InfoBarLayout.

BUG=731801
==========

[troyhildebrandt, 2017-06-12 18:44:43]

thildebr@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Maria, 2017-06-12 18:48:22]

mariakhomenko@chromium.org changed reviewers:
+ mdjones@chromium.org

[Maria, 2017-06-12 18:48:23]

+ Matt for infobar owners

https://codereview.chromium.org/2936703002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java
(right):

https://codereview.chromium.org/2936703002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:254:
if (mIconView != null) {
We should just early exit this call if mIconView is null. We don't want to
adjust the text location/size if there's no image to show.

[troyhildebrandt, 2017-06-12 18:54:58]

https://codereview.chromium.org/2936703002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java
(right):

https://codereview.chromium.org/2936703002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:254:
if (mIconView != null) {
On 2017/06/12 18:48:23, Maria wrote:
> We should just early exit this call if mIconView is null. We don't want to
> adjust the text location/size if there's no image to show.

Done.

[mdjones, 2017-06-12 20:36:27]

lgtm

[Maria, 2017-06-12 21:11:32]

lgtm

[troyhildebrandt, 2017-06-12 21:19:42]

The CQ bit was checked by thildebr@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:20:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:11:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497302382517500,
"parent_rev": "ef26b600dd5789f846869e0ef4d43296545f0258", "commit_rev":
"a34648550e4e95f355854e937c0cb1a095833681"}

[commit-bot: I haz the power, 2017-06-12 22:11:20]

Description was changed from

==========
Add null check to InfoBarLayout.setIsUsingBigIcon to avoid NPE.

It's possible for us to get a null icon from getInstantAppLaunchData, so
perform a null check before using the icon in InfoBarLayout.

BUG=731801
==========

to

==========
Add null check to InfoBarLayout.setIsUsingBigIcon to avoid NPE.

It's possible for us to get a null icon from getInstantAppLaunchData, so
perform a null check before using the icon in InfoBarLayout.

BUG=731801

Review-Url: https://codereview.chromium.org/2936703002
Cr-Commit-Position: refs/heads/master@{#478787}
Committed:
https://chromium.googlesource.com/chromium/src/+/a34648550e4e95f355854e937c0c...
==========

[commit-bot: I haz the power, 2017-06-12 22:11:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a34648550e4e95f355854e937c0c...