Chromium Code Reviews
DescriptionRevert of [Extensions Bindings] Avoid passing the event filter to JS (patchset #4 id:140001 of https://codereview.chromium.org/2924683002/ )
Reason for revert:
New test seems to be flaky on Mac...
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests__dbg_%2F41569%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FExtensionBindingsApiTest.EventOverriding%2F0
Original issue's description:
> [Extensions Bindings] Avoid passing the event filter to JS
>
> Currently, in JS bindings, we pass the event filter to JS, and then pass
> it back to C++ to find matching event listeners. This can cause problems
> because the object could be tweaked by monkey-patching, and we aren't
> correctly checking.
>
> Instead of updating the checks to safely interact with the object, just
> avoid passing it to JS altogether. Instead, pass the ids of the relevant
> listeners directly to JS. This avoids the security issue and is also
> more performant.
>
> Add a regression test.
>
> BUG=702946
>
> Review-Url: https://codereview.chromium.org/2924683002
> Cr-Commit-Position: refs/heads/master@{#478742}
> Committed: https://chromium.googlesource.com/chromium/src/+/229f3b010af25c9bc38c01cfc7c403d8b5fdecf0
TBR=jbroman@chromium.org,lazyboy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=702946
Review-Url: https://codereview.chromium.org/2936673004
Cr-Commit-Position: refs/heads/master@{#478832}
Committed: https://chromium.googlesource.com/chromium/src/+/4d2b95b2bf6bf09c38f452ba921454a234423524
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||