Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2936673004: Revert of [Extensions Bindings] Avoid passing the event filter to JS (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions Bindings] Avoid passing the event filter to JS (patchset #4 id:140001 of https://codereview.chromium.org/2924683002/ ) Reason for revert: New test seems to be flaky on Mac... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests__dbg_%2F41569%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FExtensionBindingsApiTest.EventOverriding%2F0 Original issue's description: > [Extensions Bindings] Avoid passing the event filter to JS > > Currently, in JS bindings, we pass the event filter to JS, and then pass > it back to C++ to find matching event listeners. This can cause problems > because the object could be tweaked by monkey-patching, and we aren't > correctly checking. > > Instead of updating the checks to safely interact with the object, just > avoid passing it to JS altogether. Instead, pass the ids of the relevant > listeners directly to JS. This avoids the security issue and is also > more performant. > > Add a regression test. > > BUG=702946 > > Review-Url: https://codereview.chromium.org/2924683002 > Cr-Commit-Position: refs/heads/master@{#478742} > Committed: https://chromium.googlesource.com/chromium/src/+/229f3b010af25c9bc38c01cfc7c403d8b5fdecf0 TBR=jbroman@chromium.org,lazyboy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702946 Review-Url: https://codereview.chromium.org/2936673004 Cr-Commit-Position: refs/heads/master@{#478832} Committed: https://chromium.googlesource.com/chromium/src/+/4d2b95b2bf6bf09c38f452ba921454a234423524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -109 lines) Patch
M chrome/browser/extensions/extension_bindings_apitest.cc View 9 chunks +9 lines, -17 lines 0 comments Download
D chrome/test/data/extensions/api_test/bindings/event_filter/background.js View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/api_test/bindings/event_filter/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
M extensions/renderer/event_bindings.h View 3 chunks +2 lines, -9 lines 0 comments Download
M extensions/renderer/event_bindings.cc View 7 chunks +66 lines, -56 lines 0 comments Download
M extensions/renderer/js_extension_bindings_system.cc View 2 chunks +22 lines, -2 lines 0 comments Download
M extensions/renderer/resources/event.js View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Devlin
Created Revert of [Extensions Bindings] Avoid passing the event filter to JS
3 years, 6 months ago (2017-06-13 00:11:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936673004/1
3 years, 6 months ago (2017-06-13 00:12:25 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 00:13:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d2b95b2bf6bf09c38f452ba9214...

Powered by Google App Engine
This is Rietveld 408576698