Simplify CombineFrames() interface.

Simplify CombineFrames() interface.

Also, on an unrelated note, change BidirectionalStreamTest base class
from TestWithParam<> to Test, since no parameters are used.

Review-Url: https://codereview.chromium.org/2936663002
Cr-Commit-Position: refs/heads/master@{#478786}
Committed: https://chromium.googlesource.com/chromium/src/+/ef26b600dd5789f846869e0ef4d43296545f0258

[Bence, 2017-06-12 17:24:09]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 17:24:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 18:49:12]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-06-12 18:57:37]

bnc@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Bence, 2017-06-12 18:57:38]

Zhongyi: PTAL.  Thank you.

[Zhongyi Shi, 2017-06-12 19:34:12]

Nice clean up!

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
File net/spdy/chromium/spdy_test_util_common.cc (right):

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
net/spdy/chromium/spdy_test_util_common.cc:165: // the total length.
ditto.

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
File net/spdy/chromium/spdy_test_util_common.h (right):

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
net/spdy/chromium/spdy_test_util_common.h:94: // the total length.
Could you update the comments since the return type is no longer the total
length?

[Bence, 2017-06-12 19:49:13]

PTAL.

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
File net/spdy/chromium/spdy_test_util_common.cc (right):

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
net/spdy/chromium/spdy_test_util_common.cc:165: // the total length.
On 2017/06/12 19:34:12, Zhongyi Shi wrote:
> ditto.

Done.

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
File net/spdy/chromium/spdy_test_util_common.h (right):

https://codereview.chromium.org/2936663002/diff/1/net/spdy/chromium/spdy_test...
net/spdy/chromium/spdy_test_util_common.h:94: // the total length.
On 2017/06/12 19:34:12, Zhongyi Shi wrote:
> Could you update the comments since the return type is no longer the total
> length?

Oops, sorry about that.  Good catch!

[Zhongyi Shi, 2017-06-12 19:51:16]

lgtm

Nice clean up!

[Bence, 2017-06-12 20:28:23]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-06-12 20:28:30]

On 2017/06/12 19:51:16, Zhongyi Shi wrote:
> lgtm
> 
> Nice clean up!

Thank you for the review!

[commit-bot: I haz the power, 2017-06-12 20:29:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:08:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497299303158840,
"parent_rev": "7efee7ad1dee1e8c8fcb82c680a08d13e52904f3", "commit_rev":
"ef26b600dd5789f846869e0ef4d43296545f0258"}

[commit-bot: I haz the power, 2017-06-12 22:08:33]

Description was changed from

==========
Simplify CombineFrames() interface.

Also, on an unrelated note, change BidirectionalStreamTest base class
from TestWithParam<> to Test, since no parameters are used.
==========

to

==========
Simplify CombineFrames() interface.

Also, on an unrelated note, change BidirectionalStreamTest base class
from TestWithParam<> to Test, since no parameters are used.

Review-Url: https://codereview.chromium.org/2936663002
Cr-Commit-Position: refs/heads/master@{#478786}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef26b600dd5789f846869e0ef4d4...
==========

[commit-bot: I haz the power, 2017-06-12 22:08:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ef26b600dd5789f846869e0ef4d4...