Move Google search related util methods to page_load_metrics_util

Move Google search related util methods to page_load_metrics_util

BUG=

Review-Url: https://codereview.chromium.org/2936543002
Cr-Commit-Position: refs/heads/master@{#478654}
Committed: https://chromium.googlesource.com/chromium/src/+/5ca5f6a4b4cc15fd19e68fbf6b97425601fb292c

[horo, 2017-06-12 04:10:03]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 04:10:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-06-12 04:12:02]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 04:12:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 05:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 05:02:52]

Dry run: This issue passed the CQ dry run.

[horo, 2017-06-12 07:00:40]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2017-06-12 07:00:40]

falken@
Please review this.

[falken, 2017-06-12 07:19:43]

lgtm. please get it reviewed by bmcquade also.

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
File chrome/browser/page_load_metrics/page_load_metrics_util.h (right):

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/page_load_metrics_util.h:137: // Whether the
given url has a google serch hostname.
// Google Search

Consdier adding some examples:
// https://www.google.com -> true
// https://www.google.co.jp -> true
// https://www.google.mysite.com -> false
// https://docs.google.com -> false

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/page_load_metrics_util.h:140: // Whether the
given url has a google serch result url.
"whether the URL has a XXX URL" doesn't really make sense.

Maybe "is for a Google Search results page."

Examples:
// https://www.google.co.jp/ -> true
// https://www.google.com/search -> true
// https://www.google.com/maps -> false

This is pretty complex so consider adding the Google docs link from the .cc
file.

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/page_load_metrics_util.h:143: // Whether the
given url has a google serch's redirector url.
"is a Google Search redirector URL" ?

[horo, 2017-06-12 15:02:42]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 15:03:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-06-12 15:10:37]

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
File chrome/browser/page_load_metrics/page_load_metrics_util.h (right):

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/page_load_metrics_util.h:137: // Whether the
given url has a google serch hostname.
On 2017/06/12 07:19:43, falken wrote:
> // Google Search
> 
> Consdier adding some examples:
> // https://www.google.com -> true
> // https://www.google.co.jp -> true
> // https://www.google.mysite.com -> false
> // https://docs.google.com -> false
> 
> 
> 

Done.

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/page_load_metrics_util.h:140: // Whether the
given url has a google serch result url.
On 2017/06/12 07:19:43, falken wrote:
> "whether the URL has a XXX URL" doesn't really make sense.
> 
> Maybe "is for a Google Search results page."
> 
> Examples:
> // https://www.google.co.jp/ -> true
> // https://www.google.com/search -> true
> // https://www.google.com/maps -> false
> 
> This is pretty complex so consider adding the Google docs link from the .cc
> file.
> 
> 

Done.

https://codereview.chromium.org/2936543002/diff/20001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/page_load_metrics_util.h:143: // Whether the
given url has a google serch's redirector url.
On 2017/06/12 07:19:43, falken wrote:
> "is a Google Search redirector URL" ?
> 

Done.

[horo, 2017-06-12 15:10:56]

horo@chromium.org changed reviewers:
+ bmcquade@chromium.org

[horo, 2017-06-12 15:10:56]

bmcquade@
Could you please review this?

[Bryan McQuade, 2017-06-12 15:41:20]

LGTM, thanks!

[commit-bot: I haz the power, 2017-06-12 16:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 16:00:21]

Dry run: This issue passed the CQ dry run.

[horo, 2017-06-12 16:24:06]

The CQ bit was checked by horo@chromium.org

[horo, 2017-06-12 16:24:07]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2936543002/#ps40001
(title: "incorporated falken's comment")

[commit-bot: I haz the power, 2017-06-12 16:24:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 16:30:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497284646941140,
"parent_rev": "c268151b81fb284cbca3cb72f85e33551b6f6c04", "commit_rev":
"5ca5f6a4b4cc15fd19e68fbf6b97425601fb292c"}

[commit-bot: I haz the power, 2017-06-12 16:30:40]

Description was changed from

==========
Move Google search related util methods to page_load_metrics_util

BUG=
==========

to

==========
Move Google search related util methods to page_load_metrics_util

BUG=

Review-Url: https://codereview.chromium.org/2936543002
Cr-Commit-Position: refs/heads/master@{#478654}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ca5f6a4b4cc15fd19e68fbf6b97...
==========

[commit-bot: I haz the power, 2017-06-12 16:30:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5ca5f6a4b4cc15fd19e68fbf6b97...