Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)
Patch Set: Use WebViewHelper::LocalMainFrame() where possible. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp b/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
index 1d355583f52eb8075b510d6e9086469cc0e6bbb8..aa35f4f728584c8b87a6115fcfefc29869a545af 100644
--- a/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
@@ -52,7 +52,7 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithScale) {
loader.GetDocumentLoader()->SetLoadType(kFrameLoadTypeBackForward);
web_view->SetPageScaleFactor(3.0f);
- web_view->MainFrame()->SetScrollOffset(WebSize(0, 500));
+ web_view->MainFrameImpl()->SetScrollOffset(WebSize(0, 500));
loader.GetDocumentLoader()->GetInitialScrollState().was_scrolled_by_user =
false;
loader.GetDocumentLoader()->GetHistoryItem()->SetPageScaleFactor(2);
@@ -84,7 +84,7 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithoutScale) {
loader.GetDocumentLoader()->SetLoadType(kFrameLoadTypeBackForward);
web_view->SetPageScaleFactor(3.0f);
- web_view->MainFrame()->SetScrollOffset(WebSize(0, 500));
+ web_view->MainFrameImpl()->SetScrollOffset(WebSize(0, 500));
loader.GetDocumentLoader()->GetInitialScrollState().was_scrolled_by_user =
false;
loader.GetDocumentLoader()->GetHistoryItem()->SetPageScaleFactor(0);

Powered by Google App Engine
This is Rietveld 408576698