Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1983)

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)
Patch Set: Use WebViewHelper::LocalMainFrame() where possible. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
index 7bc48f4f0c6365122643e36ce37679c446fc6df7..50ec41dae62ac0158fea270e7daf905debfa0395 100644
--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
@@ -229,7 +229,7 @@ TEST_P(VisualViewportTest, TestVisibleContentRect) {
WebViewImpl()->Resize(size);
// Scroll layout viewport and verify visibleContentRect.
- WebViewImpl()->MainFrame()->SetScrollOffset(WebSize(0, 50));
+ WebViewImpl()->MainFrameImpl()->SetScrollOffset(WebSize(0, 50));
VisualViewport& visual_viewport = GetFrame()->GetPage()->GetVisualViewport();
EXPECT_EQ(IntRect(IntPoint(0, 0), size - scrollbar_size),
@@ -330,7 +330,7 @@ TEST_P(VisualViewportTest, TestResizeAfterVerticalScroll) {
WebViewImpl()->Resize(IntSize(100, 200));
// Scroll main frame to the bottom of the document
- WebViewImpl()->MainFrame()->SetScrollOffset(WebSize(0, 400));
+ WebViewImpl()->MainFrameImpl()->SetScrollOffset(WebSize(0, 400));
EXPECT_SIZE_EQ(
ScrollOffset(0, 400),
GetFrame()->View()->LayoutViewportScrollableArea()->GetScrollOffset());
« no previous file with comments | « third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698