third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h - Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)

Patch Set: Added TODOs as suggested by dcheng@ (this patchset also accidentally includes a rebase...). Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h

diff --git a/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h b/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h

index 5fcf354e9f7d8f805acbfc0738e27f6b6c82410b..6c303a95d8a8a95764501552e974feb3c2428061 100644

--- a/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h

+++ b/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h

@@ -34,8 +34,6 @@ class CORE_EXPORT WebRemoteFrameImpl final

void Close() override;

WebString AssignedName() const override;

void SetName(const WebString&) override;

- WebSize GetScrollOffset() const override;

- void SetScrollOffset(const WebSize&) override;

WebSize ContentsSize() const override;

bool HasVisibleContent() const override;

WebRect VisibleContentRect() const override;