third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp - Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

Issue 2936423003: Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame. (Closed)

Patch Set: Added TODOs as suggested by dcheng@ (this patchset also accidentally includes a rebase...). Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

index bb30a26fa24d644d544e7a93b5eb450a8cd60c5e..6c5210cae0439983d6d6bd488518aeb0d596add2 100644

--- a/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp

@@ -90,15 +90,6 @@ void WebRemoteFrameImpl::SetName(const WebString&) {

NOTREACHED();

}

-WebSize WebRemoteFrameImpl::GetScrollOffset() const {

- NOTREACHED();

- return WebSize();

-void WebRemoteFrameImpl::SetScrollOffset(const WebSize&) {

- NOTREACHED();

WebSize WebRemoteFrameImpl::ContentsSize() const {

NOTREACHED();

return WebSize();