Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2936393003: [ObjC ARC] Converts ios/chrome/browser/ntp_tiles:ntp_tiles to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ntp_tiles:ntp_tiles to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2936393003 Cr-Commit-Position: refs/heads/master@{#479840} Committed: https://chromium.googlesource.com/chromium/src/+/ec712b77733df9b3735c278ef08e99ea5a0c0dd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ntp_tiles/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ntp_tiles/most_visited_sites_observer_bridge.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-15 15:35:21 UTC) #4
stkhapugin
lgtm
3 years, 6 months ago (2017-06-15 15:45:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936393003/1
3 years, 6 months ago (2017-06-15 17:38:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/479802)
3 years, 6 months ago (2017-06-15 19:09:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936393003/1
3 years, 6 months ago (2017-06-15 20:34:39 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 21:32:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec712b77733df9b3735c278ef08e...

Powered by Google App Engine
This is Rietveld 408576698