Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2936343002: Add support to GLRenderer for different blending for solid color quads (Closed)

Created:
3 years, 6 months ago by jbauman
Modified:
3 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support to GLRenderer for different blending for solid color quads kDstOut is a useful blending type for the hole-punching needed to draw overlays, and we want to be able to apply it to solid color quads. BUG=729238 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2936343002 Cr-Commit-Position: refs/heads/master@{#482504} Committed: https://chromium.googlesource.com/chromium/src/+/96927e55783a3f369b57f4011954302292395b0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M cc/output/gl_renderer.cc View 5 chunks +7 lines, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
jbauman
3 years, 6 months ago (2017-06-16 21:40:45 UTC) #8
enne (OOO)
lgtm
3 years, 6 months ago (2017-06-21 16:29:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936343002/1
3 years, 6 months ago (2017-06-23 02:39:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/294978)
3 years, 6 months ago (2017-06-23 02:56:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936343002/1
3 years, 5 months ago (2017-06-26 23:55:03 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 01:33:47 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96927e55783a3f369b57f4011954...

Powered by Google App Engine
This is Rietveld 408576698