Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2936293002: Disable Feature-Policy HTTP Header (Closed)

Created:
3 years, 6 months ago by iclelland
Modified:
3 years, 5 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Feature-Policy HTTP Header This is a temporary measure while the header syntax is being debated, to ensure that a format which may not be the eventual standard doesn't become relied upon by sites, and accidentally become a permanent part of the web platform. BUG=737643 Review-Url: https://codereview.chromium.org/2936293002 Cr-Commit-Position: refs/heads/master@{#483731} Committed: https://chromium.googlesource.com/chromium/src/+/b78206e4c97d23230ccfd819885e8001a8bdc795

Patch Set 1 #

Patch Set 2 : Put header under control of FeaturePolicyExperimentalFeatures flag #

Patch Set 3 : Disable layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 21 (17 generated)
iclelland
+r rbyers -- can you take a quick look?
3 years, 5 months ago (2017-06-30 15:34:27 UTC) #15
Rick Byers
LGTM As discussed, once this minimal/low-risk CL lands and is merged to M60, let's move ...
3 years, 5 months ago (2017-06-30 16:22:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936293002/40001
3 years, 5 months ago (2017-06-30 16:33:43 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 16:37:23 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b78206e4c97d23230ccfd819885e...

Powered by Google App Engine
This is Rietveld 408576698