Add chrome://flag control for features::kBrowserTouchBar

Add chrome://flag control for features::kBrowserTouchBar

Previously, the features::kBrowserTouchBar was not controllable from the
chrome://flags page. Now it is.

BUG=733393
Review-Url: https://codereview.chromium.org/2936273002
Cr-Commit-Position: refs/heads/master@{#479728}
Committed: https://chromium.googlesource.com/chromium/src/+/408bddbca79a0709ec2daa97872426c39bfe04b7

[elawrence, 2017-06-14 19:48:22]

Patchset #1 (id:1) has been deleted

[Nico, 2017-06-14 20:18:43]

Description was changed from

==========
Add chrome://flag control for features::kBrowserTouchBar

Previously, the features::kBrowserTouchBar was not controllable from the
chrome://flags page. Now it is.

BUG=none
==========

to

==========
Add chrome://flag control for features::kBrowserTouchBar

Previously, the features::kBrowserTouchBar was not controllable from the
chrome://flags page. Now it is.

BUG=733393
==========

[Nico, 2017-06-14 20:20:20]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-06-14 20:20:21]

Haha, nice :-) lgtm.

I filed a bug for this and added it to this patch's BUG= line.

We can request a merge; depends on how far along the cycle we are if it's
requested or not.

(Sarah: I can own removing this again once you want to remove the flag.)

[Nico, 2017-06-14 20:20:32]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:20:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 21:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 21:23:38]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2017-06-14 21:26:58]

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
-- looks like some xml file needs updating too, see
https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?type=cs&q=...

[elawrence, 2017-06-14 22:05:10]

On 2017/06/14 21:26:58, Nico wrote:
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> -- looks like some xml file needs updating too, see
>
https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?type=cs&q=...

Done. I didn't realize that this was needed for the new-style FEATURE_VALUE_TYPE
flags.

[Nico, 2017-06-14 22:43:57]

thakis@chromium.org changed reviewers:
+ isherman@chromium.org

[Nico, 2017-06-14 22:43:58]

isherman, can you look at the histograms change?

[spqchan, 2017-06-14 23:02:50]

On 2017/06/14 22:43:58, Nico wrote:
> isherman, can you look at the histograms change?

Nico: Sure thing, that will be great.

[Ilya Sherman, 2017-06-15 02:10:27]

On 2017/06/14 23:02:50, spqchan wrote:
> On 2017/06/14 22:43:58, Nico wrote:
> > isherman, can you look at the histograms change?
> 
> Nico: Sure thing, that will be great.

enums.xml lgtm, though you don't actually need my review for a simple addition
of enum values

[elawrence, 2017-06-15 15:14:20]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-06-15 15:14:21]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2936273002/#ps60001
(title: "Fix comment position")

[commit-bot: I haz the power, 2017-06-15 15:14:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 16:07:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497539660721240,
"parent_rev": "ee6e4420fcc4f063de108d30b6baf19b846beb82", "commit_rev":
"6b4b36c0b8754f7bca545f7c9994d13869ddcc0b"}

[commit-bot: I haz the power, 2017-06-15 16:07:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497539660721240,
"parent_rev": "788b96d0f5b55a9e8c6637a375d119419922caf9", "commit_rev":
"4e5fb3813ea117368ca4485a96d0709519dfe164"}

[commit-bot: I haz the power, 2017-06-15 16:08:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497539660721240,
"parent_rev": "3d56220ed9fd697185c345f3047507164ce09b46", "commit_rev":
"408bddbca79a0709ec2daa97872426c39bfe04b7"}

[commit-bot: I haz the power, 2017-06-15 16:08:18]

Description was changed from

==========
Add chrome://flag control for features::kBrowserTouchBar

Previously, the features::kBrowserTouchBar was not controllable from the
chrome://flags page. Now it is.

BUG=733393
==========

to

==========
Add chrome://flag control for features::kBrowserTouchBar

Previously, the features::kBrowserTouchBar was not controllable from the
chrome://flags page. Now it is.

BUG=733393

Review-Url: https://codereview.chromium.org/2936273002
Cr-Commit-Position: refs/heads/master@{#479728}
Committed:
https://chromium.googlesource.com/chromium/src/+/408bddbca79a0709ec2daa978724...
==========

[commit-bot: I haz the power, 2017-06-15 16:08:20]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/408bddbca79a0709ec2daa978724...