Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2936263003: Move onwheel to GlobalEventHandlers.idl (Closed)

Created:
3 years, 6 months ago by eirage
Modified:
3 years, 5 months ago
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, dtapuska+blinkwatch_chromium.org, blink-reviews-events_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, blink-reviews-frames_chromium.org, rwlbuis, paulmeyer
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move onwheel from Element.idl to GlobalEventHandlers Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Wa5sdcDrJnA BUG=730030 Review-Url: https://codereview.chromium.org/2936263003 Cr-Commit-Position: refs/heads/master@{#485285} Committed: https://chromium.googlesource.com/chromium/src/+/033440cd8501cdc13857fe8b6b317faa62d7be03

Patch Set 1 #

Patch Set 2 : add missing OWNER file for mac/virtual/stable/webexposed/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/events/event-handler-all-global-events-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/global-event-handlers.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/global-event-handlers-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/OWNERS View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 6 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 6 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 6 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 6 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/GlobalEventHandlers.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/GlobalEventHandlers.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 47 (40 generated)
eirage
3 years, 5 months ago (2017-07-06 14:20:14 UTC) #25
dtapuska
On 2017/07/06 14:20:14, eirage wrote: lgtm
3 years, 5 months ago (2017-07-06 14:36:49 UTC) #26
eirage
rbyers@chromium.org : Please review changes in third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt and third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
3 years, 5 months ago (2017-07-07 18:16:49 UTC) #37
eirage
On 2017/07/07 18:16:49, eirage wrote: > mailto:rbyers@chromium.org : Please review changes in > > third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt ...
3 years, 5 months ago (2017-07-07 18:18:45 UTC) #38
Rick Byers
*/virtual/stable* LGTM Thanks for adding the missing OWNERS! Sorry for the extra /platform/ hassle here, ...
3 years, 5 months ago (2017-07-07 20:10:05 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936263003/120001
3 years, 5 months ago (2017-07-10 13:43:10 UTC) #44
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 16:13:06 UTC) #47
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/033440cd8501cdc13857fe8b6b31...

Powered by Google App Engine
This is Rietveld 408576698