Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2936163002: Re-enable media query API test (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable media query API test Remove the remaining images tests that used the JS setColorProfile API, and re-enable the media query API test. The media query picture test needs rebaselineing and is in a separate patch. TBR=enne (for the not-lazy solution) TBR=avi (for content/) BUG=731783 Review-Url: https://codereview.chromium.org/2936163002 Cr-Commit-Position: refs/heads/master@{#479310} Committed: https://chromium.googlesource.com/chromium/src/+/188ad8e21510e3e8ff10465711c11a13a28936f3

Patch Set 1 #

Patch Set 2 : Just API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-canvas.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-canvas-svg.html View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936163002/20001
3 years, 6 months ago (2017-06-14 05:06:07 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 06:58:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/188ad8e21510e3e8ff10465711c1...

Powered by Google App Engine
This is Rietveld 408576698