Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: pkg/analysis_server/test/search/element_references_test.dart

Issue 2936123002: Convert more tests (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/edit/refactoring_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/search/element_references_test.dart
diff --git a/pkg/analysis_server/test/search/element_references_test.dart b/pkg/analysis_server/test/search/element_references_test.dart
index 136799a40d1507216e6cdd440e616cfdba40989e..0756353e8ac65674ee5fbabca2c72fd3a7a519b9 100644
--- a/pkg/analysis_server/test/search/element_references_test.dart
+++ b/pkg/analysis_server/test/search/element_references_test.dart
@@ -22,9 +22,6 @@ main() {
class ElementReferencesTest extends AbstractSearchDomainTest {
Element searchElement;
- @override
- bool get enableNewAnalysisDriver => false;
-
void assertHasRef(SearchResultKind kind, String search, bool isPotential) {
assertHasResult(kind, search);
expect(result.isPotential, isPotential);
@@ -406,7 +403,8 @@ main() {
}
''');
await findElementReferences('fff(p) {}', false);
- expect(results, isEmpty);
+ expect(results, hasLength(1));
+ assertHasResult(SearchResultKind.INVOCATION, 'fff(10);');
}
test_parameter() async {
@@ -427,7 +425,9 @@ main(ppp) {
assertHasResult(SearchResultKind.INVOCATION, 'ppp();');
}
+ @failingTest
test_path_inConstructor_named() async {
+ // The path does not contain the first expected element.
addTestFile('''
library my_lib;
class A {}
@@ -449,7 +449,9 @@ COMPILATION_UNIT test.dart
LIBRARY my_lib''');
}
+ @failingTest
test_path_inConstructor_unnamed() async {
+ // The path does not contain the first expected element.
addTestFile('''
library my_lib;
class A {}
@@ -471,7 +473,9 @@ COMPILATION_UNIT test.dart
LIBRARY my_lib''');
}
+ @failingTest
test_path_inFunction() async {
+ // The path does not contain the first expected element.
addTestFile('''
library my_lib;
class A {}
« no previous file with comments | « pkg/analysis_server/test/edit/refactoring_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698