Convert more tests

pkg/analysis_server/test/search/element_references_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/protocol/protocol.dart';
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import 'abstract_search_domain.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(ElementReferencesTest);
   });
 }
 
 @reflectiveTest
 class ElementReferencesTest extends AbstractSearchDomainTest {
   Element searchElement;
 
-  @override
-  bool get enableNewAnalysisDriver => false;
-
   void assertHasRef(SearchResultKind kind, String search, bool isPotential) {
     assertHasResult(kind, search);
     expect(result.isPotential, isPotential);
   }
 
   Future<Null> findElementReferences(
       String search, bool includePotential) async {
     int offset = findOffset(search);
     await waitForTasksFinished();
     Request request = new SearchFindElementReferencesParams(
@@ skipping 361 matching lines @@
 
   test_oneUnit_zeroLibraries() async {
     addTestFile('''
 part of lib;
 fff(p) {}
 main() {
   fff(10);
 }
 ''');
     await findElementReferences('fff(p) {}', false);
-    expect(results, isEmpty);
+    expect(results, hasLength(1));
+    assertHasResult(SearchResultKind.INVOCATION, 'fff(10);');
   }
 
   test_parameter() async {
     addTestFile('''
 main(ppp) {
   print(ppp);
   ppp += 3;
   ppp = 2;
   ppp();
 }
 ''');
     await findElementReferences('ppp) {', false);
     expect(searchElement.kind, ElementKind.PARAMETER);
     expect(results, hasLength(4));
     assertHasResult(SearchResultKind.READ, 'ppp);');
     assertHasResult(SearchResultKind.READ_WRITE, 'ppp += 3');
     assertHasResult(SearchResultKind.WRITE, 'ppp = 2');
     assertHasResult(SearchResultKind.INVOCATION, 'ppp();');
   }
 
+  @failingTest
   test_path_inConstructor_named() async {
+    // The path does not contain the first expected element.
     addTestFile('''
 library my_lib;
 class A {}
 class B {
   B.named() {
     A a = null;
   }
 }
 ''');
     await findElementReferences('A {}', false);
     assertHasResult(SearchResultKind.REFERENCE, 'A a = null;');
     expect(
         getPathString(result.path),
         '''
 LOCAL_VARIABLE a
 CONSTRUCTOR named
 CLASS B
 COMPILATION_UNIT test.dart
 LIBRARY my_lib''');
   }
 
+  @failingTest
   test_path_inConstructor_unnamed() async {
+    // The path does not contain the first expected element.
     addTestFile('''
 library my_lib;
 class A {}
 class B {
   B() {
     A a = null;
   }
 }
 ''');
     await findElementReferences('A {}', false);
     assertHasResult(SearchResultKind.REFERENCE, 'A a = null;');
     expect(
         getPathString(result.path),
         '''
 LOCAL_VARIABLE a
 CONSTRUCTOR
 CLASS B
 COMPILATION_UNIT test.dart
 LIBRARY my_lib''');
   }
 
+  @failingTest
   test_path_inFunction() async {
+    // The path does not contain the first expected element.
     addTestFile('''
 library my_lib;
 class A {}
 main() {
   A a = null;
 }
 ''');
     await findElementReferences('A {}', false);
     assertHasResult(SearchResultKind.REFERENCE, 'A a = null;');
     expect(
@@ skipping 182 matching lines @@
   T m() => null;
 }
 ''');
     await findElementReferences('T> {', false);
     expect(searchElement.kind, ElementKind.TYPE_PARAMETER);
     expect(results, hasLength(2));
     assertHasResult(SearchResultKind.REFERENCE, 'T f;');
     assertHasResult(SearchResultKind.REFERENCE, 'T m()');
   }
 }