Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Issue 2936123002: Convert more tests (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -155 lines) Patch
M pkg/analysis_server/test/analysis/get_errors_test.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 5 chunks +16 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 8 chunks +24 lines, -68 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 14 chunks +35 lines, -45 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 5 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I believe that this is the last of the non-driver tests in server. Next I ...
3 years, 6 months ago (2017-06-14 00:54:37 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-14 01:14:48 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-14 02:39:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0d7d64f0bce27f73750541d82914550efaa6a27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698