Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 2936113002: Revert of Remove unit tests from ios-simulator that are timing out. (Closed)

Created:
3 years, 6 months ago by robliao
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org, Dirk Pranke, justincohen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unit tests from ios-simulator that are timing out. (patchset #1 id:1 of https://codereview.chromium.org/2925663005/ ) Reason for revert: Re-adding ios_chrome_unittests and net_unittests as 728216 appears to be fixed. Original issue's description: > Remove unit tests from ios-simulator that are timing out. > > ios_chrome_unittests and net_unittests are timing out a lot > on the bots, so remove them from the CQ and main. > > BUG=728216 > > Review-Url: https://codereview.chromium.org/2925663005 > Cr-Commit-Position: refs/heads/master@{#477477} > Committed: https://chromium.googlesource.com/chromium/src/+/a27564e55ec5fd0ff168c23d927c68dec145871c TBR=liaoyuke@chromium.org,rohitrao@chromium.org,baxley@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=728216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/build/bots/tests/common_tests.json View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robliao
Created Revert of Remove unit tests from ios-simulator that are timing out.
3 years, 6 months ago (2017-06-14 00:43:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936113002/1
3 years, 6 months ago (2017-06-14 00:43:55 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/463179)
3 years, 6 months ago (2017-06-14 00:53:08 UTC) #5
rohitrao (ping after 24h)
I believe we added these back to the CQ last week.
3 years, 6 months ago (2017-06-14 00:58:19 UTC) #6
robliao
3 years, 6 months ago (2017-06-14 16:32:30 UTC) #7
On 2017/06/14 00:58:19, rohitrao (ping after 24h) wrote:
> I believe we added these back to the CQ last week.

Looks like I can't read. I was checking against trunk and the entries looked
like they weren't there. I see them now.

Powered by Google App Engine
This is Rietveld 408576698