Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2925663005: Remove unit tests from ios-simulator that are timing out. (Closed)

Created:
3 years, 6 months ago by baxley
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org, Dirk Pranke, justincohen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unit tests from ios-simulator that are timing out. ios_chrome_unittests and net_unittests are timing out a lot on the bots, so remove them from the CQ and main. BUG=728216 Review-Url: https://codereview.chromium.org/2925663005 Cr-Commit-Position: refs/heads/master@{#477477} Committed: https://chromium.googlesource.com/chromium/src/+/a27564e55ec5fd0ff168c23d927c68dec145871c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M ios/build/bots/tests/common_tests.json View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
liaoyuke
lgtm
3 years, 6 months ago (2017-06-06 23:56:03 UTC) #2
baxley
3 years, 6 months ago (2017-06-06 23:56:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925663005/1
3 years, 6 months ago (2017-06-06 23:57:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a27564e55ec5fd0ff168c23d927c68dec145871c
3 years, 6 months ago (2017-06-07 00:16:25 UTC) #9
robliao
3 years, 6 months ago (2017-06-14 00:43:26 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2936113002/ by robliao@chromium.org.

The reason for reverting is: Re-adding ios_chrome_unittests and net_unittests as
728216 appears to be fixed..

Powered by Google App Engine
This is Rietveld 408576698