Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2936053002: Use JumpList icon caches to remove redundant favicon loading (Closed)

Created:
3 years, 6 months ago by chengx
Modified:
3 years, 6 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use JumpList icon caches to remove redundant favicon loading This CL applies the icon caches to save unnecessary favicon loading from the FaviconService. The icon caches have already been used to trim out the redundant icon creation and deletion on disk as in crrev/2859193005. These two changes make the best of the icon caches. BUG=40407, 717236 Review-Url: https://codereview.chromium.org/2936053002 Cr-Commit-Position: refs/heads/master@{#480122} Committed: https://chromium.googlesource.com/chromium/src/+/0cf2ecfa1dfa8ab1626c75d1d27bf01be3e7aa10

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into usecachetosaveiconfetch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/win/jumplist.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
chengx
Hi Greg, PTAL at this small CL. Thanks!
3 years, 6 months ago (2017-06-13 22:43:01 UTC) #11
grt (UTC plus 2)
lgtm
3 years, 6 months ago (2017-06-14 10:57:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936053002/20001
3 years, 6 months ago (2017-06-16 18:39:25 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 19:28:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0cf2ecfa1dfa8ab1626c75d1d27b...

Powered by Google App Engine
This is Rietveld 408576698