Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2935983002: [ObjC ARC] Converts ios/web:ios_web_navigation_unittests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_navigation_unittests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935983002 Cr-Commit-Position: refs/heads/master@{#479369} Committed: https://chromium.googlesource.com/chromium/src/+/a2e2ad05197890aea5ada3a0a17a6143f231f15c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -104 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/navigation/crw_navigation_item_storage_unittest.mm View 5 chunks +13 lines, -10 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 28 chunks +77 lines, -74 lines 0 comments Download
M ios/web/navigation/crw_session_storage_unittest.mm View 4 chunks +7 lines, -4 lines 0 comments Download
M ios/web/navigation/navigation_item_impl_unittest.mm View 1 chunk +4 lines, -1 line 0 comments Download
M ios/web/navigation/navigation_item_storage_test_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 4 chunks +9 lines, -6 lines 0 comments Download
M ios/web/navigation/nscoder_util_unittest.mm View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-14 12:06:59 UTC) #10
Eugene But (OOO till 7-30)
lgtm
3 years, 6 months ago (2017-06-14 13:28:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935983002/1
3 years, 6 months ago (2017-06-14 13:31:49 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 13:35:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2e2ad05197890aea5ada3a0a17a...

Powered by Google App Engine
This is Rietveld 408576698