Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2935933003: [ObjC ARC] Converts ios/web:ios_web_web_state_unittests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_web_state_unittests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935933003 Cr-Commit-Position: refs/heads/master@{#479400} Committed: https://chromium.googlesource.com/chromium/src/+/19c5a8a7ff6d04e4688a1a88a3d57ef620fab6ab

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -63 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/context_menu_params_utils_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader_unittest.mm View 4 chunks +7 lines, -4 lines 0 comments Download
M ios/web/web_state/error_translation_util_unittest.mm View 5 chunks +17 lines, -14 lines 0 comments Download
M ios/web/web_state/navigation_context_impl_unittest.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/page_display_state_unittest.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ios/web/web_state/web_state_delegate_bridge_unittest.mm View 6 chunks +16 lines, -16 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 3 chunks +10 lines, -10 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge_unittest.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M ios/web/web_state/web_state_unittest.mm View 3 chunks +12 lines, -7 lines 0 comments Download
M ios/web/web_state/web_view_internal_creation_util_unittest.mm View 2 chunks +4 lines, -1 line 0 comments Download
M ios/web/web_state/wk_web_view_security_util_unittest.mm View 1 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-14 12:08:25 UTC) #10
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2935933003/diff/1/ios/web/web_state/page_display_state_unittest.mm File ios/web/web_state/page_display_state_unittest.mm (right): https://codereview.chromium.org/2935933003/diff/1/ios/web/web_state/page_display_state_unittest.mm#newcode64 ios/web/web_state/page_display_state_unittest.mm:64: NSDictionary* serialization = state.GetSerialization(); Optional nit: consider dropping ...
3 years, 6 months ago (2017-06-14 13:34:03 UTC) #11
marq (ping after 24h)
Thanks for the review! https://codereview.chromium.org/2935933003/diff/1/ios/web/web_state/page_display_state_unittest.mm File ios/web/web_state/page_display_state_unittest.mm (right): https://codereview.chromium.org/2935933003/diff/1/ios/web/web_state/page_display_state_unittest.mm#newcode64 ios/web/web_state/page_display_state_unittest.mm:64: NSDictionary* serialization = state.GetSerialization(); On ...
3 years, 6 months ago (2017-06-14 14:18:23 UTC) #12
marq (ping after 24h)
Review fixes.
3 years, 6 months ago (2017-06-14 14:20:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935933003/20001
3 years, 6 months ago (2017-06-14 14:21:06 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 15:49:11 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19c5a8a7ff6d04e4688a1a88a3d5...

Powered by Google App Engine
This is Rietveld 408576698