[Android] Remove RetryOnFailure from WebApkIntegrationTest

[Android] Remove RetryOnFailure from WebApkIntegrationTest

It is likely that the source of flakiness was fixed by
https://codereview.chromium.org/2859053004

BUG=708523
Review-Url: https://codereview.chromium.org/2935903002
Cr-Commit-Position: refs/heads/master@{#479710}
Committed: https://chromium.googlesource.com/chromium/src/+/3ac2c353dc23284cca32db9ca76a21567f77e088

[pkotwicz, 2017-06-13 01:09:26]

Description was changed from

==========
[Android] Remove RetryOnFailure from WebApkIntegrationTest

It is likely that the source of flakiness was fixed by
https://codereview.chromium.org/2859053004

BUG=708523

Merge branch 'master' of https://chromium.googlesource.com/chromium/src
==========

to

==========
[Android] Remove RetryOnFailure from WebApkIntegrationTest

It is likely that the source of flakiness was fixed by
https://codereview.chromium.org/2859053004

BUG=708523
==========

[pkotwicz, 2017-06-13 01:09:27]

pkotwicz@chromium.org changed reviewers:
+ jbudorick@chromium.org

[pkotwicz, 2017-06-13 01:16:15]

jbudorick@ can you please take a look?

I think that WebApkIntegrationTest was marked as flaky because the
WebApkIntegration test waits for several events prior to calling
ChromeTabUtils#waitForTabPageLoaded() and thus is more likely to call
ChromeTabUtils#waitForTabPageLoaded() after the page has finished loading.

Based on the stack trace from the bug, it looks like flakiness is due to a bug
in ChromeTabUtils#waitForTabPageLoaded()

Here is the relevant bit from the bug:
junit.framework.AssertionFailedError: Page did not load.  Tab information at
time of failure -- url:
http://127.0.0.1:41287/chrome/test/data/android/test.html, final URL:
http://127.0.0.1:41287/chrome/test/data/android/test.html, load progress: 100,
is loading: false

[pkotwicz, 2017-06-15 04:59:22]

jbudorick@ Ping!

[jbudorick, 2017-06-15 12:56:59]

Sorry about the delay -- slipped through the email cracks. lgtm

On 2017/06/13 01:16:15, pkotwicz wrote:
> jbudorick@ can you please take a look?
> 
> I think that WebApkIntegrationTest was marked as flaky because the
> WebApkIntegration test waits for several events prior to calling
> ChromeTabUtils#waitForTabPageLoaded() and thus is more likely to call
> ChromeTabUtils#waitForTabPageLoaded() after the page has finished loading.
> 
> Based on the stack trace from the bug, it looks like flakiness is due to a bug
> in ChromeTabUtils#waitForTabPageLoaded()
> 
> Here is the relevant bit from the bug:
> junit.framework.AssertionFailedError: Page did not load.  Tab information at
> time of failure -- url:
> http://127.0.0.1:41287/chrome/test/data/android/test.html, final URL:
> http://127.0.0.1:41287/chrome/test/data/android/test.html, load progress: 100,
> is loading: false

This was https://bugs.chromium.org/p/chromium/issues/detail?id=709004, which I
*think* is fixed.

[pkotwicz, 2017-06-15 14:39:56]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2017-06-15 14:39:56]

Yaron for OWNERS

[Yaron, 2017-06-15 14:42:36]

lgtm

[Yaron, 2017-06-15 14:42:37]

The CQ bit was checked by yfriedman@chromium.org

[Yaron, 2017-06-15 14:42:38]

lgtm

lgtm

[commit-bot: I haz the power, 2017-06-15 14:42:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 15:22:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497537757284410, "parent_rev":
"bf9d1c2f8e5ea0366b4b086c7d0541bdc15ab176", "commit_rev":
"3ac2c353dc23284cca32db9ca76a21567f77e088"}

[commit-bot: I haz the power, 2017-06-15 15:22:21]

Description was changed from

==========
[Android] Remove RetryOnFailure from WebApkIntegrationTest

It is likely that the source of flakiness was fixed by
https://codereview.chromium.org/2859053004

BUG=708523
==========

to

==========
[Android] Remove RetryOnFailure from WebApkIntegrationTest

It is likely that the source of flakiness was fixed by
https://codereview.chromium.org/2859053004

BUG=708523

Review-Url: https://codereview.chromium.org/2935903002
Cr-Commit-Position: refs/heads/master@{#479710}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ac2c353dc23284cca32db9ca76a...
==========

[commit-bot: I haz the power, 2017-06-15 15:22:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ac2c353dc23284cca32db9ca76a...