Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2935893002: Change DataPersistent constructor to allow one line initialisation. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
nainar
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DataPersistent constructor to allow one line initialisation. Currently, DataPersistent objects must be initialised twice: once via the constructor that sets it to nullptr and once more via the Init() method that sets it to a nonnull value. This patch changes the default constructor to do Init() instead and adds an extra constructor that sets it to nullptr. This way, we can initialise DataPersistent objects in one line (useful for constructor initializer lists). BUG=628043 Review-Url: https://codereview.chromium.org/2935893002 Cr-Commit-Position: refs/heads/master@{#478883} Committed: https://chromium.googlesource.com/chromium/src/+/3adbcbaa43c1d5069da92d154a7382943c5a2881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/DataPersistent.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Naina, PTAL
3 years, 6 months ago (2017-06-13 00:55:08 UTC) #4
nainar
lgtm
3 years, 6 months ago (2017-06-13 00:56:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935893002/1
3 years, 6 months ago (2017-06-13 03:16:12 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 03:19:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3adbcbaa43c1d5069da92d154a73...

Powered by Google App Engine
This is Rietveld 408576698