Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2935873002: Revert "Address additional analysis issues in the observatory codebase." (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Address additional analysis issues in the observatory codebase." This reverts commit 2ea426a50982a84efab0fccc0a1a64256c72603a. Platform.script doesn't necessarily point to source. TBR=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/f02d34362eee59d2566d5d8b5cf340b56b96c88a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -118 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 4 chunks +7 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/async_next_test.dart View 2 chunks +12 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_exception_test.dart View 2 chunks +19 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_into_test.dart View 2 chunks +12 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_out_test.dart View 2 chunks +14 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/async_star_single_step_into_test.dart View 2 chunks +16 lines, -10 lines 0 comments Download
M runtime/observatory/tests/service/async_star_step_out_test.dart View 3 chunks +25 lines, -16 lines 0 comments Download
M runtime/observatory/tests/service/async_step_out_test.dart View 2 chunks +14 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_frame_with_scope_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_with_scope_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_native_allocation_samples_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 2 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
rmacnak
Committed patchset #1 (id:1) manually as f02d34362eee59d2566d5d8b5cf340b56b96c88a.
3 years, 6 months ago (2017-06-12 22:10:44 UTC) #2
devoncarew
3 years, 6 months ago (2017-06-12 22:57:19 UTC) #3
Message was sent while issue was closed.
lgtm

Ah, I see the failure here:
https://build.chromium.org/p/client.dart/builders/app-linux-debug-x64-be/buil...

lgtm

Powered by Google App Engine
This is Rietveld 408576698