runtime/observatory/tests/service/evaluate_in_frame_with_scope_test.dart - Issue 2935873002: Revert "Address additional analysis issues in the observatory codebase."

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/observatory/tests/service/evaluate_in_frame_with_scope_test.dart

Issue 2935873002: Revert "Address additional analysis issues in the observatory codebase." (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « runtime/observatory/tests/service/async_step_out_test.dart ('k') | runtime/observatory/tests/service/evaluate_with_scope_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4 // VMOptions=--error_on_bad_type --error_on_bad_override	4 // VMOptions=--error_on_bad_type --error_on_bad_override

5	5

	6 import 'dart:async';

6 import 'dart:developer';	7 import 'dart:developer';

7

8 import 'package:observatory/service_io.dart';	8 import 'package:observatory/service_io.dart';

9 import 'package:unittest/unittest.dart';	9 import 'package:unittest/unittest.dart';

10

11 import 'service_test_common.dart';	10 import 'service_test_common.dart';

12 import 'test_helper.dart';	11 import 'test_helper.dart';

13	12

14 var thing1;	13 var thing1;

15 var thing2;	14 var thing2;

16	15

17 testeeMain() {	16 testeeMain() {

18 thing1 = 3;	17 thing1 = 3;

19 thing2 = 4;	18 thing2 = 4;

20 foo(42, 1984);	19 foo(42, 1984);

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 print(result);	77 print(result);

79 } catch (e) {	78 } catch (e) {

80 didThrow = true;	79 didThrow = true;

81 expect(e.toString(), contains("invalid 'scope' parameter"));	80 expect(e.toString(), contains("invalid 'scope' parameter"));

82 }	81 }

83 expect(didThrow, isTrue);	82 expect(didThrow, isTrue);

84 },	83 },

85 ];	84 ];

86	85

87 main(args) => runIsolateTests(args, tests, testeeConcurrent: testeeMain);	86 main(args) => runIsolateTests(args, tests, testeeConcurrent: testeeMain);

OLD	NEW