[Android Refactor] Reland: Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID

[Android Refactor] Reland: Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID

Having both LAST_USED_UNSET and LAST_USED_INVALID is unnecessary as
- the "last_used" SharedPreference should never be set to LAST_USED_INVALID
- there isn't any logic which checks whether "last_used" is LAST_USED_INVALID

Additionally, this CL renames LAST_USED_INVALID to TIMESTAMP_INVALID as
the getters for several time-based SharedPreferences other than "last_used"
return LAST_USED_INVALID if the preference is unset.

BUG=None

Review-Url: https://codereview.chromium.org/2935853002
Cr-Commit-Position: refs/heads/master@{#479116}
Committed: https://chromium.googlesource.com/chromium/src/+/6a35c14886cb036360d829b23a295af8fad93406

[pkotwicz, 2017-06-13 00:18:44]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2017-06-13 00:20:01]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-06-13 00:20:01]

Dominick, can you please take a look? This CL is a reland of 
https://codereview.chromium.org/2927723003/

Patch set #1 has the CL as it previously landed

[dominickn, 2017-06-13 01:36:58]

lgtm with a question

https://codereview.chromium.org/2935853002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
(right):

https://codereview.chromium.org/2935853002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java:116:
// The first read from {@link WebappDataStorage} must be done in the background.
This is an interesting restriction! Is it new?

[pkotwicz, 2017-06-13 03:14:29]

https://codereview.chromium.org/2935853002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
(right):

https://codereview.chromium.org/2935853002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java:116:
// The first read from {@link WebappDataStorage} must be done in the background.
Thank you for your question! It forced me to do more investigation. The strict
mode exception is thrown by SharedPreferencesImpl#awaitLoadLocked() if the
SharedPreferences have not finished loading.
http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/...

We would get a strict mode exception if we tried to access SharedPreferences
immediately after the strict mode block in WebappActivity#preInflationStartup()
(I checked that this is the case)

[pkotwicz, 2017-06-13 16:58:16]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-06-13 16:58:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2935853002/#ps60001
(title: "ABCD")

[commit-bot: I haz the power, 2017-06-13 16:58:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkotwicz, 2017-06-13 16:58:59]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2017-06-13 17:00:30]

Patchset #3 (id:60001) has been deleted

[pkotwicz, 2017-06-13 17:04:55]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-06-13 17:04:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2935853002/#ps80001
(title: "Merge branch 'master' into reland")

[commit-bot: I haz the power, 2017-06-13 17:05:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:07:18]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pkotwicz, 2017-06-13 19:07:17]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-06-13 19:07:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 20:09:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497380837143020,
"parent_rev": "edce82add95cef7cf2cd64d2b8b5d8c62790dd3a", "commit_rev":
"6a35c14886cb036360d829b23a295af8fad93406"}

[commit-bot: I haz the power, 2017-06-13 20:10:05]

Description was changed from

==========
[Android Refactor] Reland: Merge WebappDataStorage#LAST_USED_UNSET and
LAST_USED_INVALID

Having both LAST_USED_UNSET and LAST_USED_INVALID is unnecessary as
- the "last_used" SharedPreference should never be set to LAST_USED_INVALID
- there isn't any logic which checks whether "last_used" is LAST_USED_INVALID

Additionally, this CL renames LAST_USED_INVALID to TIMESTAMP_INVALID as
the getters for several time-based SharedPreferences other than "last_used"
return LAST_USED_INVALID if the preference is unset.

BUG=None
==========

to

==========
[Android Refactor] Reland: Merge WebappDataStorage#LAST_USED_UNSET and
LAST_USED_INVALID

Having both LAST_USED_UNSET and LAST_USED_INVALID is unnecessary as
- the "last_used" SharedPreference should never be set to LAST_USED_INVALID
- there isn't any logic which checks whether "last_used" is LAST_USED_INVALID

Additionally, this CL renames LAST_USED_INVALID to TIMESTAMP_INVALID as
the getters for several time-based SharedPreferences other than "last_used"
return LAST_USED_INVALID if the preference is unset.

BUG=None

Review-Url: https://codereview.chromium.org/2935853002
Cr-Commit-Position: refs/heads/master@{#479116}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a35c14886cb036360d829b23a29...
==========

[commit-bot: I haz the power, 2017-06-13 20:10:06]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6a35c14886cb036360d829b23a29...

[dominickn, 2017-06-13 23:13:21]

https://codereview.chromium.org/2935853002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
(right):

https://codereview.chromium.org/2935853002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java:116:
// The first read from {@link WebappDataStorage} must be done in the background.
On 2017/06/13 03:14:29, pkotwicz wrote:
> Thank you for your question! It forced me to do more investigation. The strict
> mode exception is thrown by SharedPreferencesImpl#awaitLoadLocked() if the
> SharedPreferences have not finished loading.
>
http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/...
> 
> We would get a strict mode exception if we tried to access SharedPreferences
> immediately after the strict mode block in
WebappActivity#preInflationStartup()
> (I checked that this is the case)

Perhaps this bit of code should be moved to warmUpSharedPrefs then? The whole
purpose of warming shared prefs is to avoid this issue in one go....