Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2935823003: Add ifdef guard to WorkletModuleTreeClient.h (Closed)

Created:
3 years, 6 months ago by ckulakowski
Modified:
3 years, 6 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ifdef guard to WorkletModuleTreeClient.h We use "jumbo" compilation of blink in our project. The main idea is to compile some number of cc files as one compilation unit. It significantly speeds up compilation time of blink. With "jumbo" enabled there is compilation error due to lack of ifdef guard in file WorkletModuleTreeClient.h. BUG=732727 Review-Url: https://codereview.chromium.org/2935823003 Cr-Commit-Position: refs/heads/master@{#478967} Committed: https://chromium.googlesource.com/chromium/src/+/e8ebeebd9d4e9c9b0459f8adcfc1bcc5b7af08b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ckulakowski
3 years, 6 months ago (2017-06-13 08:37:27 UTC) #2
nhiroki
LGTM. Thank you for fixing this!
3 years, 6 months ago (2017-06-13 09:23:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935823003/1
3 years, 6 months ago (2017-06-13 09:25:50 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 11:39:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8ebeebd9d4e9c9b0459f8adcfc1...

Powered by Google App Engine
This is Rietveld 408576698