third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2935813002: "Find" scrolling should be smoothly animated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2935813002: "Find" scrolling should be smoothly animated. (Closed)

Patch Set: Rebase and set ScrollRectToVisibleRecursive() to private. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index e31a15ba917ac60211ce405a3072e80fae1ad9d7..1647ec030e815d4be9462f5a80a0dd854ee9666d 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1615,10 +1615,13 @@ Range* Editor::FindStringAndScrollToVisible(const String& target,

return nullptr;

Node* first_node = next_match->FirstNode();

first_node->GetLayoutObject()->ScrollRectToVisible(

LayoutRect(next_match->BoundingBox()),

ScrollAlignment::kAlignCenterIfNeeded,

- ScrollAlignment::kAlignCenterIfNeeded, kUserScroll);

+ ScrollAlignment::kAlignCenterIfNeeded, kProgrammaticScroll, true,

+ kScrollBehaviorSmooth);

first_node->GetDocument().SetSequentialFocusNavigationStartingPoint(

first_node);