Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2935813002: "Find" scrolling should be smoothly animated. (Closed)
Patch Set: Rebase and set ScrollRectToVisibleRecursive() to private. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/Editor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index 2bff5dd11379c36c67f38b0ed22ff2aca0c99c7e..8551dcefa802a6446a45b7c648e23dff405b99ee 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -528,15 +528,11 @@ void Element::scrollIntoViewWithOptions(const ScrollIntoViewOptions& options) {
ScrollAlignment align_y =
ToPhysicalAlignment(options, kVerticalScroll, is_horizontal_writing_mode);
- GetDocument().GetPage()->GetSmoothScrollSequencer()->AbortAnimations();
LayoutRect bounds = BoundingBox();
GetLayoutObject()->ScrollRectToVisible(
bounds, align_x, align_y, kProgrammaticScroll,
make_visible_in_visual_viewport, behavior);
- if (behavior == kScrollBehaviorSmooth)
- GetDocument().GetPage()->GetSmoothScrollSequencer()->RunQueuedAnimations();
-
GetDocument().SetSequentialFocusNavigationStartingPoint(this);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/Editor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698