Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2935753002: exo: Update cursor on wl_pointer::set_cursor (Closed)

Created:
3 years, 6 months ago by Dominik Laskowski
Modified:
3 years, 6 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Update cursor on wl_pointer::set_cursor The cursor scale and rotation must be updated on pointer enter, even though neither the surface nor the hotspot changed. BUG=730843 TEST=caroline: Cursor is not stale on pointer enter. Review-Url: https://codereview.chromium.org/2935753002 Cr-Commit-Position: refs/heads/master@{#478660} Committed: https://chromium.googlesource.com/chromium/src/+/1a58cb060e6c628db1e36f824bd2c6ed1ec1ae14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M components/exo/pointer.cc View 1 chunk +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Dominik Laskowski
PTAL. Previously, the client incorrectly forced a surface change on pointer enter.
3 years, 6 months ago (2017-06-12 15:59:54 UTC) #4
reveman
lgtm
3 years, 6 months ago (2017-06-12 16:12:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935753002/1
3 years, 6 months ago (2017-06-12 16:34:51 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 16:38:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a58cb060e6c628db1e36f824bd2...

Powered by Google App Engine
This is Rietveld 408576698