Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2935743002: [ObjC ARC] Converts ios/chrome/browser/ui/popup_menu:popup_menu to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/popup_menu:popup_menu to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935743002 Cr-Commit-Position: refs/heads/master@{#478977} Committed: https://chromium.googlesource.com/chromium/src/+/20cc9fcf43e66ba7b877df2c8b15378bcef8300a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M ios/chrome/browser/ui/popup_menu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/popup_menu/popup_menu_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm View 6 chunks +4 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/popup_menu/popup_menu_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/popup_menu/popup_menu_view.mm View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 17:10:49 UTC) #6
stkhapugin
lgtm
3 years, 6 months ago (2017-06-13 12:01:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935743002/1
3 years, 6 months ago (2017-06-13 12:04:03 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 12:08:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20cc9fcf43e66ba7b877df2c8b15...

Powered by Google App Engine
This is Rietveld 408576698