Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2935693004: Rewrite editing/deleting/smart-editing-disabled-{mac,win}.html to utilize assert_selection() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite editing/deleting/smart-editing-disabled-{mac,win}.html to utilize assert_selection() This patch introduces "smart_editing_disabled.html" as replacement of "editing/deleting/smart-editing-disabled-{mac,win}.html" to utilize |assert_selection()| for ease of maintaining test case. Because of "smart_editing_disabled.html" doesn't depend on word granularity selection modification, all platforms yield same result. BUG=731756 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2935693004 Cr-Commit-Position: refs/heads/master@{#479301} Committed: https://chromium.googlesource.com/chromium/src/+/00058c119c207251ac6423b6a9eebedabdf6941f

Patch Set 1 : 2017-06-14T13:25:00 #

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-14 05:37:14 UTC) #7
yoichio
lgtm
3 years, 6 months ago (2017-06-14 05:58:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935693004/1
3 years, 6 months ago (2017-06-14 06:06:53 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 06:11:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00058c119c207251ac6423b6a9ee...

Powered by Google App Engine
This is Rietveld 408576698