Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2935673002: Use ContainsValue() instead of std::find() in device/bluetooth and device/hid (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 6 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in device/bluetooth and device/hid BUG=561800 Review-Url: https://codereview.chromium.org/2935673002 Cr-Commit-Position: refs/heads/master@{#478907} Committed: https://chromium.googlesource.com/chromium/src/+/1aafc6b9d8fd263a4bac55fbc8c7842b65de585c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 12 chunks +37 lines, -36 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M device/hid/hid_connection.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tripta
Hi Reilly, Please review code change in below files: device/bluetooth/bluez/bluetooth_bluez_unittest.cc device/bluetooth/dbus/fake_bluetooth_device_client.cc device/hid/hid_connection.cc Regards Tripta
3 years, 6 months ago (2017-06-12 11:25:33 UTC) #3
Reilly Grant (use Gerrit)
lgtm
3 years, 6 months ago (2017-06-12 18:47:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935673002/1
3 years, 6 months ago (2017-06-13 03:14:06 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 05:14:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1aafc6b9d8fd263a4bac55fbc8c7...

Powered by Google App Engine
This is Rietveld 408576698