Add histograms for enospc cryptomigration errors.

Add histograms for enospc cryptomigration errors.

During ecryptfs->ext4-crypto migration we are getting some ENOSPC errors
which are not well understood.  Add UMA metrics to attempt to get a
better understanding as to the cause of these errors.
Metrics reporting added in
https://chromium-review.googlesource.com/c/527742/

BUG=731505
TEST=./validate_format.py && ./pretty_print.py

Review-Url: https://codereview.chromium.org/2935633002
Cr-Commit-Position: refs/heads/master@{#478864}
Committed: https://chromium.googlesource.com/chromium/src/+/b5cd8f14b7d6df9fd446db36661bfefa19e4e080

[dspaid, 2017-06-12 06:47:24]

dspaid@chromium.org changed reviewers:
+ hashimoto@chromium.org, rkaplow@chromium.org

[dspaid, 2017-06-12 06:47:25]

ptal

[hashimoto, 2017-06-12 06:52:52]

https://codereview.chromium.org/2935633002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2935633002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:9981: +    The total mount of free disk
space on the system when the user started the
nit: s/mount/amount/?

https://codereview.chromium.org/2935633002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:10004: +    set.  Recorder during
ecryptfs to ext4-crypto migration if we receive an
nit: s/Recorder/Recorded/?

The descriptions of existing Cryptohome.Dircrypto* histograms say "logged", but
in this CL you are using "reported", "collected", and "recorded".
Could you stick to one verb to be consistent?

[dspaid, 2017-06-12 07:00:19]

https://codereview.chromium.org/2935633002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2935633002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:9981: +    The total mount of free disk
space on the system when the user started the
On 2017/06/12 06:52:51, hashimoto wrote:
> nit: s/mount/amount/?

Done.

https://codereview.chromium.org/2935633002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:10004: +    set.  Recorder during
ecryptfs to ext4-crypto migration if we receive an
On 2017/06/12 06:52:51, hashimoto wrote:
> nit: s/Recorder/Recorded/?
> 
> The descriptions of existing Cryptohome.Dircrypto* histograms say "logged",
but
> in this CL you are using "reported", "collected", and "recorded".
> Could you stick to one verb to be consistent?

Done.

[hashimoto, 2017-06-12 07:04:28]

lgtm

[rkaplow, 2017-06-12 14:34:55]

lgtm

https://codereview.chromium.org/2935633002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2935633002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:10001: +    The total number of bytse of
xattr data that we are trying to store on a
bytes

[dspaid, 2017-06-13 00:30:15]

https://codereview.chromium.org/2935633002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2935633002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:10001: +    The total number of bytse of
xattr data that we are trying to store on a
On 2017/06/12 14:34:54, rkaplow wrote:
> bytes

Done.

[dspaid, 2017-06-13 00:30:28]

The CQ bit was checked by dspaid@chromium.org

[dspaid, 2017-06-13 00:30:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2935633002/#ps40001
(title: "Add histograms for enospc cryptomigration errors.")

[commit-bot: I haz the power, 2017-06-13 00:31:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 02:09:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497313828015440,
"parent_rev": "3f75d51156f340e994e89f272d42c2d90d343fd3", "commit_rev":
"b5cd8f14b7d6df9fd446db36661bfefa19e4e080"}

[commit-bot: I haz the power, 2017-06-13 02:09:43]

Description was changed from

==========
Add histograms for enospc cryptomigration errors.

During ecryptfs->ext4-crypto migration we are getting some ENOSPC errors
which are not well understood.  Add UMA metrics to attempt to get a
better understanding as to the cause of these errors.
Metrics reporting added in
https://chromium-review.googlesource.com/c/527742/

BUG=728970
TEST=./validate_format.py && ./pretty_print.py
==========

to

==========
Add histograms for enospc cryptomigration errors.

During ecryptfs->ext4-crypto migration we are getting some ENOSPC errors
which are not well understood.  Add UMA metrics to attempt to get a
better understanding as to the cause of these errors.
Metrics reporting added in
https://chromium-review.googlesource.com/c/527742/

BUG=728970
TEST=./validate_format.py && ./pretty_print.py

Review-Url: https://codereview.chromium.org/2935633002
Cr-Commit-Position: refs/heads/master@{#478864}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5cd8f14b7d6df9fd446db36661b...
==========

[commit-bot: I haz the power, 2017-06-13 02:09:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b5cd8f14b7d6df9fd446db36661b...

[dspaid, 2017-06-14 01:35:51]

Description was changed from

==========
Add histograms for enospc cryptomigration errors.

During ecryptfs->ext4-crypto migration we are getting some ENOSPC errors
which are not well understood.  Add UMA metrics to attempt to get a
better understanding as to the cause of these errors.
Metrics reporting added in
https://chromium-review.googlesource.com/c/527742/

BUG=728970
TEST=./validate_format.py && ./pretty_print.py

Review-Url: https://codereview.chromium.org/2935633002
Cr-Commit-Position: refs/heads/master@{#478864}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5cd8f14b7d6df9fd446db36661b...
==========

to

==========
Add histograms for enospc cryptomigration errors.

During ecryptfs->ext4-crypto migration we are getting some ENOSPC errors
which are not well understood.  Add UMA metrics to attempt to get a
better understanding as to the cause of these errors.
Metrics reporting added in
https://chromium-review.googlesource.com/c/527742/

BUG=731505
TEST=./validate_format.py && ./pretty_print.py

Review-Url: https://codereview.chromium.org/2935633002
Cr-Commit-Position: refs/heads/master@{#478864}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5cd8f14b7d6df9fd446db36661b...
==========