[Cleanup] Clean up the VariationsSeedStore's histograms.

[Cleanup] Clean up the VariationsSeedStore's histograms.

* Rename Variations.SeedEmpty to Variations.SeedLoadResult, and only record it
  when loading the seed on startup. (Previously, half of the enum values were
  also recorded when storing a seed, which makes the metric quite confusing to
  interpret.)
* Use enum classes in place of regular enums (IMO this makes the constant names
  a bit easier to read.)
* Move most of the metrics recording code out of the variations_seed_store.cc
  implementation file into a separate helper file.

BUG=none
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2935623004
Cr-Commit-Position: refs/heads/master@{#479411}
Committed: https://chromium.googlesource.com/chromium/src/+/5f556b51553f6a8b163987dc56594f337192f38d

[Ilya Sherman, 2017-06-13 02:24:51]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 02:25:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-06-13 02:33:18]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 02:33:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 02:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 02:46:59]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Ilya Sherman, 2017-06-13 04:48:26]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 04:48:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 05:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 05:03:12]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Ilya Sherman, 2017-06-13 05:11:45]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 05:11:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 06:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 06:35:32]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-06-13 15:26:37]

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
File components/variations/variations_seed_store.cc (right):

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
components/variations/variations_seed_store.cc:322: if
(base64_seed_data.empty()) {
Nit: No {}s

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
File components/variations/variations_seed_store_unittest.cc (right):

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
components/variations/variations_seed_store_unittest.cc:290:
ASSERT_FALSE(VariationsSeedStore(&prefs).SignatureVerificationEnabled());
Could we just enable verification for the test?

[Ilya Sherman, 2017-06-13 22:33:35]

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
File components/variations/variations_seed_store.cc (right):

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
components/variations/variations_seed_store.cc:322: if
(base64_seed_data.empty()) {
On 2017/06/13 15:26:37, Alexei Svitkine (slow) wrote:
> Nit: No {}s

Done.

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
File components/variations/variations_seed_store_unittest.cc (right):

https://codereview.chromium.org/2935623004/diff/60001/components/variations/v...
components/variations/variations_seed_store_unittest.cc:290:
ASSERT_FALSE(VariationsSeedStore(&prefs).SignatureVerificationEnabled());
On 2017/06/13 15:26:37, Alexei Svitkine (slow) wrote:
> Could we just enable verification for the test?

Done.

[Ilya Sherman, 2017-06-13 22:33:54]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 22:34:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 00:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 00:20:22]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-06-14 02:34:53]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 02:35:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 04:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 04:38:05]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-06-14 15:02:58]

lgtm, thanks

[Ilya Sherman, 2017-06-14 16:18:42]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-06-14 16:19:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 16:27:27]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497457122213380,
"parent_rev": "76353515c29ef2aa801870e533f770895f3512a1", "commit_rev":
"5f556b51553f6a8b163987dc56594f337192f38d"}

[commit-bot: I haz the power, 2017-06-14 16:27:38]

Description was changed from

==========
[Cleanup] Clean up the VariationsSeedStore's histograms.

* Rename Variations.SeedEmpty to Variations.SeedLoadResult, and only record it
  when loading the seed on startup. (Previously, half of the enum values were
  also recorded when storing a seed, which makes the metric quite confusing to
  interpret.)
* Use enum classes in place of regular enums (IMO this makes the constant names
  a bit easier to read.)
* Move most of the metrics recording code out of the variations_seed_store.cc
  implementation file into a separate helper file.

BUG=none
TEST=none
R=asvitkine@chromium.org
==========

to

==========
[Cleanup] Clean up the VariationsSeedStore's histograms.

* Rename Variations.SeedEmpty to Variations.SeedLoadResult, and only record it
  when loading the seed on startup. (Previously, half of the enum values were
  also recorded when storing a seed, which makes the metric quite confusing to
  interpret.)
* Use enum classes in place of regular enums (IMO this makes the constant names
  a bit easier to read.)
* Move most of the metrics recording code out of the variations_seed_store.cc
  implementation file into a separate helper file.

BUG=none
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2935623004
Cr-Commit-Position: refs/heads/master@{#479411}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f556b51553f6a8b163987dc5659...
==========

[commit-bot: I haz the power, 2017-06-14 16:27:40]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5f556b51553f6a8b163987dc5659...