Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2935603002: ICU unbundling fixes (Closed)

Created:
3 years, 6 months ago by Mike Gilbert
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ICU unbundling fixes Update instructions to generate ICU header lists Update header list for unbundling ICU 59 Bug: https://bugs.gentoo.org/619796#c2 Review-Url: https://codereview.chromium.org/2935603002 Cr-Commit-Position: refs/heads/master@{#478662} Committed: https://chromium.googlesource.com/chromium/src/+/1394c5c05f173523fa6958ef15f398152cf645b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M build/linux/unbundle/icu.gn View 8 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mike Gilbert
3 years, 6 months ago (2017-06-11 15:25:34 UTC) #3
Paweł Hajdan Jr.
LGTM (assuming this works with the older ICU as well; additions of shim headers are ...
3 years, 6 months ago (2017-06-12 12:19:01 UTC) #4
Mike Gilbert
On 2017/06/12 12:19:01, Paweł Hajdan Jr. wrote: > LGTM (assuming this works with the older ...
3 years, 6 months ago (2017-06-12 14:48:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935603002/1
3 years, 6 months ago (2017-06-12 14:49:12 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 16:45:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1394c5c05f173523fa6958ef15f3...

Powered by Google App Engine
This is Rietveld 408576698