Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2935553002: fix checking of dsend generic type bounds (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly
Modified:
3 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -32 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 1 2 3 chunks +32 lines, -25 lines 0 comments Download
M tests/language_strong/generic_function_bounds_test.dart View 1 2 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Dynamic call bounds were not actually being checked (!) this was hidden because the test, ...
3 years, 6 months ago (2017-06-10 03:52:04 UTC) #2
vsm
lgtm
3 years, 6 months ago (2017-06-12 22:52:33 UTC) #3
Jennifer Messerly
3 years, 6 months ago (2017-06-12 23:17:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
71c79140612bb76ab857e1d9955758909b4c5045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698