fix checking of dsend generic type bounds

pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This library defines the representation of runtime types.
 part of dart._runtime;
 
 final metadata = JS('', 'Symbol("metadata")');
 
 /// The symbol used to store the cached `Type` object associated with a class.
@@ skipping 469 matching lines @@
           .substring(1, end)
           .split(',')
           .map((n) => new TypeVariable(n.trim()))
           .toList();
     } else {
       _typeFormals = [new TypeVariable(str.substring(0, end).trim())];
     }
     return _typeFormals;
   }
 
+  checkBounds(List typeArgs) {
+    var bounds = instantiateTypeBounds(typeArgs);
+    var typeFormals = this.typeFormals;
+    for (var i = 0; i < typeArgs.length; i++) {
+      var type = typeArgs[i];
+      var bound = bounds[i];
+      if (!JS('bool', '#', isSubtype(type, bound))) {
+        throwStrongModeError('type `$type` does not extend `$bound`'
+            ' of `${typeFormals[i]}`.');
+      }
+    }
+  }
+
   instantiate(typeArgs) {
     var parts = JS('', '#.apply(null, #)', _instantiateTypeParts, typeArgs);
     return JS('', '#.create(#, #[0], #[1], #[2])', FunctionType, definite,
         parts, parts, parts);
   }
 
   List instantiateTypeBounds(List typeArgs) {
     var boundsFn = _instantiateTypeBounds;
     if (boundsFn == null) {
       // The Dart 1 spec says omitted type parameters have an upper bound of
@@ skipping 281 matching lines @@
   // Check return type last, so that arity mismatched functions can be
   // definitively rejected.
 
   // For `void` we will give the same answer as the VM, so don't return null.
   if (ret1 === $_void) return $_isTop(ret2);
 
   if (!$_isSubtype(ret1, ret2, $isCovariant)) return null;
   return true;
 })()''');
 
-/// TODO(leafp): This duplicates code in operations.dart.
-/// I haven't found a way to factor it out that makes the
-/// code generator happy though.
-_subtypeMemo(f) => JS(
-    '',
-    '''(() => {
-  let memo = new Map();
-  return (t1, t2) => {
-    let map = memo.get(t1);
-    let result;
-    if (map) {
-      result = map.get(t2);
-      if (result !== void 0) return result;
-    } else {
-      memo.set(t1, map = new Map());
-    }
-    result = $f(t1, t2);
-    map.set(t2, result);
-    return result;
-  };
-})()''');
-
 /// Returns true if [t1] <: [t2].
 /// Returns false if [t1] </: [t2] in both spec and strong mode
 /// Returns undefined if [t1] </: [t2] in strong mode, but spec
 ///  mode may differ
-final isSubtype = JS(
-    '', '$_subtypeMemo((t1, t2) => (t1 === t2) || $_isSubtype(t1, t2, true))');
+bool isSubtype(t1, t2) {
+  // TODO(leafp): This duplicates code in operations.dart.
+  // I haven't found a way to factor it out that makes the
+  // code generator happy though.
+  var map = JS('', '#.get(#)', _memo, t1);
+  bool result;
+  if (JS('bool', '# !== void 0', map)) {
+    result = JS('bool', '#.get(#)', map, t2);
+    if (JS('bool', '# !== void 0', result)) return result;
+  } else {
+    JS('', '#.set(#, # = new Map())', _memo, t1, map);
+  }
+  result = JS('', '# === # || #(#, #, true)', t1, t2, _isSubtype, t1, t2);
+  JS('', '#.set(#, #)', map, t2, result);
+  return result;
+}
+
+final _memo = JS('', 'new Map()');
 
 _isBottom(type) => JS('bool', '# == # || # == #', type, bottom, type, Null);
 
 _isTop(type) {
   if (_isFutureOr(type)) {
     return _isTop(JS('', '#[0]', getGenericArgs(type)));
   }
   return JS('bool', '# == # || # == # || # == #', type, Object, type, dynamic,
       type, _void);
 }
 
 bool _isFutureOr(type) =>
     JS('bool', '# === #', getGenericClass(type), getGenericClass(FutureOr));
 
-_isSubtype(t1, t2, isCovariant) => JS(
+bool _isSubtype(t1, t2, isCovariant) => JS(
     '',
     '''(() => {
   if ($t1 === $t2) return true;
 
   // Trivially true.
   if ($_isTop($t2) || $_isBottom($t1)) {
     return true;
   }
 
   // Trivially false.
@@ skipping 213 matching lines @@
     return true;
   }
 
   let typeArgs = $getGenericArgs($type);
   if (!typeArgs) return true;
   for (let t of typeArgs) {
     if (t != $Object && t != $dynamic) return false;
   }
   return true;
 })()''');