Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2935533002: Fix wrong explicit marked for zero-parameter constructor (Closed)

Created:
3 years, 6 months ago by jinsong.fan
Modified:
3 years, 6 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong explicit marked for zero-parameter constructor Remove unnecessary explicit for zero-parameter constructor in AwContentBrowserClient and AwJavaScriptDialogManager. BUG= TEST= R=sgurun@chromium.org Review-Url: https://codereview.chromium.org/2935533002 Cr-Commit-Position: refs/heads/master@{#478523} Committed: https://chromium.googlesource.com/chromium/src/+/2ad97e65a9dd2ecb87342532c22d713f1841c621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_javascript_dialog_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jinsong.fan
Hi Sgurun, I find unnecessary explicit marked for zero-parameter constructor in AwContentBrowserClient and AwJavaScriptDialogManager. PTAL, ...
3 years, 6 months ago (2017-06-09 23:50:25 UTC) #1
sgurun-gerrit only
On 2017/06/09 23:50:25, jinsong.fan wrote: > Hi Sgurun, > > I find unnecessary explicit marked ...
3 years, 6 months ago (2017-06-10 00:00:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935533002/1
3 years, 6 months ago (2017-06-10 22:57:22 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-10 23:42:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ad97e65a9dd2ecb87342532c22d...

Powered by Google App Engine
This is Rietveld 408576698