Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2935473002: [web] Fix duplicate dep, strengthen provisioning. (Closed)

Created:
3 years, 6 months ago by dnj (Google)
Modified:
3 years, 6 months ago
Reviewers:
dnj, Ryan Tseng, dsansome, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[web] Fix duplicate dep, strengthen provisioning. Remove the unnecessary "es6-promise" polyfill from "package.json". This became unnecessary when TypeScript was instructed to build with ES6. Update "web.py" to purge existing Node/Bower directories when their deps change, rather than just ensure them. We do this because we don't want residual packages from previous specifications to still be importable. BUG=chromium:731519 TEST=local - Reproduced the failure in the bug. - Works with this patch. Review-Url: https://codereview.chromium.org/2935473002 Committed: https://github.com/luci/luci-go/commit/e65d27b76fb791d6ee6e47c510fa9aa398557f2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M web/apps/gulp-common.js View 1 chunk +0 lines, -2 lines 0 comments Download
M web/package.json View 1 chunk +0 lines, -1 line 0 comments Download
M web/web.py View 5 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dnj
PTAL
3 years, 6 months ago (2017-06-09 15:00:15 UTC) #2
Ryan Tseng
lgtm
3 years, 6 months ago (2017-06-09 17:23:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935473002/1
3 years, 6 months ago (2017-06-09 17:24:33 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 17:29:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e65d27b76fb791d6ee6e47c510fa9aa398557f2f

Powered by Google App Engine
This is Rietveld 408576698