Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2935453004:
Remove 1 second timeouts from HttpServerTests. (Closed)
DescriptionRemove 1 second timeouts from HttpServerTests.
On some systems, starting up NSS takes longer than that. In general,
tests shouldn't be relying on timeouts, anyways, beyond the shared
per-test timeout.
BUG=731829
Review-Url: https://codereview.chromium.org/2935453004
Cr-Commit-Position: refs/heads/master@{#479086}
Committed: https://chromium.googlesource.com/chromium/src/+/8e2811b4b174030c9d0af24781fc2dfdf9e75ad9
Patch Set 1 #Patch Set 2 : Fix test #
Total comments: 1
Messages
Total messages: 18 (13 generated)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mmenke@chromium.org changed reviewers: + eroman@chromium.org
Oops, forgot to send this out over the weekend. https://codereview.chromium.org/2935453004/diff/20001/net/server/http_server_... File net/server/http_server_unittest.cc (right): https://codereview.chromium.org/2935453004/diff/20001/net/server/http_server_... net/server/http_server_unittest.cc:731: client.Send("GET / HTTP/1.1\r\n\r\n"); The fact that this always succeeds seems a bit weird...
LGTM
in CL description:
s/One some systems/On some systems/
Description was changed from ========== Remove 1 second timeouts from HttpServerTests. One some systems, starting up NSS takes longer than that. In general, tests shouldn't be relying on timeouts, anyways, beyond the shared per-test timeout. BUG=731829 ========== to ========== Remove 1 second timeouts from HttpServerTests. On some systems, starting up NSS takes longer than that. In general, tests shouldn't be relying on timeouts, anyways, beyond the shared per-test timeout. BUG=731829 ==========
On 2017/06/13 18:03:24, eroman wrote: > LGTM > > in CL description: > s/One some systems/On some systems/ Done.
The CQ bit was checked by mmenke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497377063797670,
"parent_rev": "71d7600294c2dfd5b0636ec760076053a7f6e4d1", "commit_rev":
"8e2811b4b174030c9d0af24781fc2dfdf9e75ad9"}
Message was sent while issue was closed.
Description was changed from ========== Remove 1 second timeouts from HttpServerTests. On some systems, starting up NSS takes longer than that. In general, tests shouldn't be relying on timeouts, anyways, beyond the shared per-test timeout. BUG=731829 ========== to ========== Remove 1 second timeouts from HttpServerTests. On some systems, starting up NSS takes longer than that. In general, tests shouldn't be relying on timeouts, anyways, beyond the shared per-test timeout. BUG=731829 Review-Url: https://codereview.chromium.org/2935453004 Cr-Commit-Position: refs/heads/master@{#479086} Committed: https://chromium.googlesource.com/chromium/src/+/8e2811b4b174030c9d0af24781fc... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8e2811b4b174030c9d0af24781fc... |
